fix(clp-package): Disable Docker interactive mode when running `sbin` scripts non-interactively (fixes #1566). by junhaoliao · Pull Request #1567 · y-scope/clp

junhaoliao · 2025-11-06T23:40:06Z

Description

Problem

When sbin scripts were run in the background (e.g., ./sbin/compress.sh ~/samples/hive-24hr &), the Docker container's output (stdout/stderr) was not being forwarded to the terminal. The job would run successfully, but users couldn't see any progress, logs, or errors.

This happened because:

docker compose run has stdin_open: true and tty: true enabled by default no matter what value is set (undocumented) in docker-compose.runtime.yaml, not to mention we should have set stdin_open: false.
When running with &, the shell is non-interactive and stdin is detached
Docker Compose's interactive mode would prevent proper output forwarding in this scenario

Solution

Removed stdin_open: true and tty: true from docker-compose.runtime.yaml (they default to false)
Added CLP_COMPOSE_RUN_EXTRA_FLAGS array in .common-env.sh that detects non-interactive shells using [[ $- != *i* ]]
When the shell is non-interactive, adds --interactive=false flag to all docker compose run commands
Updated all sbin scripts to use "${CLP_COMPOSE_RUN_EXTRA_FLAGS[@]}" in their compose commands

Checklist

The PR satisfies the contribution guidelines.
This is a breaking change and that has been indicated in the PR title, OR this isn't a
breaking change.
Necessary docs have been updated, OR no docs need to be updated.

Validation performed

junhao@GIGABYTE:~/workspace/2-clp/build/clp-package$ ./sbin/start-clp.sh 
2025-11-06T23:35:44.843 INFO [controller] Setting up environment for database...
2025-11-06T23:35:44.846 INFO [controller] Setting up environment for queue...
2025-11-06T23:35:44.846 INFO [controller] Setting up environment for redis...
2025-11-06T23:35:44.847 INFO [controller] Setting up environment for results_cache...
2025-11-06T23:35:44.848 INFO [controller] Setting up environment for compression_scheduler...
2025-11-06T23:35:44.848 INFO [controller] Setting up environment for query_scheduler...
2025-11-06T23:35:44.848 INFO [controller] Setting up environment for compression_worker...
2025-11-06T23:35:44.848 INFO [controller] Setting up environment for query_worker...
2025-11-06T23:35:44.848 INFO [controller] Setting up environment for reducer...
2025-11-06T23:35:44.849 INFO [controller] Setting up environment for webui...
2025-11-06T23:35:44.850 INFO [controller] The MCP Server is not configured, skipping mcp_server creation...
2025-11-06T23:35:44.850 INFO [controller] Setting up environment for garbage_collector...
2025-11-06T23:35:44.959 INFO [controller] Starting CLP using Docker Compose (full deployment)...
[+] Running 14/14
 ✔ Network clp-package-b7df_default                            Created          0.2s 
 ✔ Container clp-package-b7df-results-cache-1                  Healthy         17.8s 
 ✔ Container clp-package-b7df-redis-1                          Healthy         17.8s 
 ✔ Container clp-package-b7df-query-worker-1                   Healthy         17.8s 
 ✔ Container clp-package-b7df-database-1                       Healthy         17.8s 
 ✔ Container clp-package-b7df-compression-worker-1             Healthy         17.8s 
 ✔ Container clp-package-b7df-queue-1                          Healthy         17.8s 
 ✔ Container clp-package-b7df-db-table-creator-1               Exited          17.5s 
 ✔ Container clp-package-b7df-results-cache-indices-creator-1  Exited          17.3s 
 ✔ Container clp-package-b7df-compression-scheduler-1          Healthy         17.2s 
 ✔ Container clp-package-b7df-query-scheduler-1                Healthy         17.2s 
 ✔ Container clp-package-b7df-webui-1                          Healthy         17.1s 
 ✔ Container clp-package-b7df-garbage-collector-1              Healthy         17.1s 
 ✔ Container clp-package-b7df-reducer-1                        Healthy         17.0s 
2025-11-06T23:36:03.196 INFO [controller] Started CLP.
junhao@GIGABYTE:~/workspace/2-clp/build/clp-package$ ./sbin/compress.sh ~/samples/hive-24hr/
2025-11-06T23:36:13.959 INFO [compress] Compression job 1 submitted.
2025-11-06T23:36:18.970 INFO [compress] Compressed 1.99GB into 44.92MB (45.33x). Speed: 694.51MB/s.
2025-11-06T23:36:19.472 INFO [compress] Compression finished.
2025-11-06T23:36:19.472 INFO [compress] Compressed 1.99GB into 44.92MB (45.33x). Speed: 644.37MB/s.
junhao@GIGABYTE:~/workspace/2-clp/build/clp-package$ ./sbin/compress.sh ~/samples/hive-24hr/ &
[1] 701023
junhao@GIGABYTE:~/workspace/2-clp/build/clp-package$ ./sbin/compress.sh ~/samples/hive-24hr/ &
[2] 701644
junhao@GIGABYTE:~/workspace/2-clp/build/clp-package$ ./sbin/compress.sh ~/samples/hive-24hr/ &
[3] 701949
junhao@GIGABYTE:~/workspace/2-clp/build/clp-package$ 2025-11-06T23:36:26.244 INFO [compress] Compression job 2 submitted.
2025-11-06T23:36:26.562 INFO [compress] Compression job 3 submitted.
2025-11-06T23:36:27.261 INFO [compress] Compression job 4 submitted.
2025-11-06T23:36:30.756 INFO [compress] Compressed 192.56MB into 5.06MB (38.09x). Speed: 87.69MB/s.
2025-11-06T23:36:31.257 INFO [compress] Compressed 704.70MB into 18.01MB (39.13x). Speed: 261.30MB/s.
2025-11-06T23:36:31.759 INFO [compress] Compressed 1.99GB into 44.92MB (45.33x). Speed: 636.67MB/s.
2025-11-06T23:36:35.084 INFO [compress] Compressed 192.56MB into 5.06MB (38.09x). Speed: 77.09MB/s.
2025-11-06T23:36:35.586 INFO [compress] Compressed 1.99GB into 44.92MB (45.33x). Speed: 678.83MB/s.
2025-11-06T23:36:36.272 INFO [compress] Compression finished.
2025-11-06T23:36:36.272 INFO [compress] Compressed 1.99GB into 44.92MB (45.33x). Speed: 272.19MB/s.
2025-11-06T23:36:36.588 INFO [compress] Compression finished.
2025-11-06T23:36:36.588 INFO [compress] Compressed 1.99GB into 44.92MB (45.33x). Speed: 513.73MB/s.
2025-11-06T23:36:37.787 INFO [compress] Compressed 192.56MB into 5.06MB (38.09x). Speed: 83.63MB/s.
2025-11-06T23:36:38.289 INFO [compress] Compressed 960.75MB into 24.42MB (39.34x). Speed: 342.64MB/s.
2025-11-06T23:36:38.790 INFO [compress] Compression finished.
2025-11-06T23:36:38.790 INFO [compress] Compressed 1.99GB into 44.92MB (45.33x). Speed: 701.06MB/s.

[1]   Done                    ./sbin/compress.sh ~/samples/hive-24hr/
[2]-  Done                    ./sbin/compress.sh ~/samples/hive-24hr/
[3]+  Done                    ./sbin/compress.sh ~/samples/hive-24hr/
junhao@GIGABYTE:~/workspace/2-clp/build/clp-package$ ./sbin/stop-clp.sh &
[1] 704202
junhao@GIGABYTE:~/workspace/2-clp/build/clp-package$ 2025-11-06T23:37:12.977 INFO [controller] Stopping all CLP containers using Docker Compose...
[+] Running 14/14
 ✔ Container clp-package-b7df-compression-scheduler-1          Removed          2.4s 
 ✔ Container clp-package-b7df-reducer-1                        Removed         11.5s 
 ✔ Container clp-package-b7df-garbage-collector-1              Removed         11.4s 
 ✔ Container clp-package-b7df-compression-worker-1             Removed          4.2s 
 ✔ Container clp-package-b7df-webui-1                          Removed          1.9s 
 ✔ Container clp-package-b7df-query-worker-1                   Removed          3.7s 
 ✔ Container clp-package-b7df-query-scheduler-1                Removed         11.1s 
 ✔ Container clp-package-b7df-results-cache-indices-creator-1  Removed          0.2s 
 ✔ Container clp-package-b7df-results-cache-1                  Removed          1.8s 
 ✔ Container clp-package-b7df-db-table-creator-1               Removed          0.2s 
 ✔ Container clp-package-b7df-queue-1                          Removed          2.7s 
 ✔ Container clp-package-b7df-redis-1                          Removed          1.5s 
 ✔ Container clp-package-b7df-database-1                       Removed          1.8s 
 ✔ Network clp-package-b7df_default                            Removed          2.3s 
2025-11-06T23:37:40.658 INFO [controller] Stopped CLP.

[1]+  Done                    ./sbin/stop-clp.sh
junhao@GIGABYTE:~/workspace/2-clp/build/clp-package$

Observed that:

ANSI colors were correctly shown in start-clp.sh and stop-clp.sh, no matter when running with or without &.
When the compress.sh was run with &, stdin was detached and therefore i could quickly run another compress.sh command. The outputs of those commands were printed to the console.

Summary by CodeRabbit

Release Notes

New Features
- Added support for passing extra Docker Compose runtime flags to CLI commands for enhanced execution flexibility.
Changes
- Removed interactive TTY allocation from the runtime service to better support non-interactive execution modes.

… scripts non-interactively (fixes y-scope#1566).

coderabbitai · 2025-11-06T23:40:16Z

Walkthrough

The changes introduce a CLP_COMPOSE_RUN_EXTRA_FLAGS array mechanism in the common environment script to pass dynamic flags to docker compose run commands. This array includes --interactive=false for non-interactive shells and is now injected into all docker compose run invocations across the deployment scripts. Additionally, TTY and stdin settings are removed from the runtime docker-compose configuration.

Changes

Cohort / File(s)	Summary
Environment Configuration `components/package-template/src/sbin/.common-env.sh`	Introduces `CLP_COMPOSE_RUN_EXTRA_FLAGS` array declaration and conditionally appends `--interactive=false` when shell is non-interactive.
Docker Compose Run Commands `components/package-template/src/sbin/admin-tools/archive-manager.sh`, `admin-tools/dataset-manager.sh`, `compress-from-s3.sh`, `compress.sh`, `decompress.sh`, `search.sh`, `start-clp.sh`, `stop-clp.sh`	Injects `CLP_COMPOSE_RUN_EXTRA_FLAGS` array expansion into docker compose run invocations by repositioning the array reference immediately after the `run --rm` subcommand and before the service name.
Runtime Configuration `tools/deployment/package/docker-compose.runtime.yaml`	Removes `stdin_open: true` and `tty: true` settings from the clp-runtime service definition.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Consistency verification: Ensure all eight shell scripts apply the CLP_COMPOSE_RUN_EXTRA_FLAGS expansion consistently in the correct position within docker compose run commands
Array syntax validation: Confirm proper bash array expansion syntax ("${CLP_COMPOSE_RUN_EXTRA_FLAGS[@]}") is used throughout
TTY removal impact: Verify that removing stdin_open and tty settings does not break expected interactive functionality for use cases that rely on them

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately and specifically describes the main change: disabling Docker interactive mode for non-interactive sbin script execution, directly addressing the issue.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✨ Finishing touches

📝 Generate docstrings

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: ASSERTIVE

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between d7c65f5 and 3b2876b.

📒 Files selected for processing (10)

components/package-template/src/sbin/.common-env.sh (1 hunks)
components/package-template/src/sbin/admin-tools/archive-manager.sh (1 hunks)
components/package-template/src/sbin/admin-tools/dataset-manager.sh (1 hunks)
components/package-template/src/sbin/compress-from-s3.sh (1 hunks)
components/package-template/src/sbin/compress.sh (1 hunks)
components/package-template/src/sbin/decompress.sh (1 hunks)
components/package-template/src/sbin/search.sh (1 hunks)
components/package-template/src/sbin/start-clp.sh (1 hunks)
components/package-template/src/sbin/stop-clp.sh (1 hunks)
tools/deployment/package/docker-compose.runtime.yaml (0 hunks)

💤 Files with no reviewable changes (1)

tools/deployment/package/docker-compose.runtime.yaml

🧰 Additional context used

🧠 Learnings (8)

📓 Common learnings

Learnt from: junhaoliao
Repo: y-scope/clp PR: 1414
File: tools/docker-images/clp-package/Dockerfile:20-24
Timestamp: 2025-10-13T03:32:19.293Z
Learning: In the clp repository's Dockerfiles (e.g., tools/docker-images/clp-package/Dockerfile), ENV directives should be split into separate lines for readability rather than consolidated to reduce layer count. This is especially true for PATH modifications, as agreed upon in PR #1166. Later ENV settings may depend on earlier ones (e.g., referencing CLP_HOME).

Learnt from: jackluo923
Repo: y-scope/clp PR: 1054
File: components/core/tools/docker-images/clp-env-base-musllinux_1_2-aarch64/build.sh:3-5
Timestamp: 2025-07-07T17:43:04.349Z
Learning: In CLP project build scripts (specifically build.sh files in docker-images directories), maintain consistency with the established pattern of using separate `set -eu` and `set -o pipefail` commands rather than combining them into `set -euo pipefail`, to ensure uniform script structure across all platform build scripts.

📚 Learning: 2025-10-13T03:32:19.293Z

Learnt from: junhaoliao
Repo: y-scope/clp PR: 1414
File: tools/docker-images/clp-package/Dockerfile:20-24
Timestamp: 2025-10-13T03:32:19.293Z
Learning: In the clp repository's Dockerfiles (e.g., tools/docker-images/clp-package/Dockerfile), ENV directives should be split into separate lines for readability rather than consolidated to reduce layer count. This is especially true for PATH modifications, as agreed upon in PR #1166. Later ENV settings may depend on earlier ones (e.g., referencing CLP_HOME).

Applied to files:

components/package-template/src/sbin/admin-tools/dataset-manager.sh
components/package-template/src/sbin/.common-env.sh
components/package-template/src/sbin/stop-clp.sh
components/package-template/src/sbin/decompress.sh
components/package-template/src/sbin/admin-tools/archive-manager.sh
components/package-template/src/sbin/compress.sh
components/package-template/src/sbin/search.sh
components/package-template/src/sbin/start-clp.sh
components/package-template/src/sbin/compress-from-s3.sh

📚 Learning: 2025-10-20T21:05:30.417Z

Learnt from: junhaoliao
Repo: y-scope/clp PR: 1413
File: tools/docker-images/clp-package/Dockerfile:22-24
Timestamp: 2025-10-20T21:05:30.417Z
Learning: In the clp repository's Dockerfiles, ENV directives should be consolidated into multi-line ENV statements when possible to reduce image layers. ENV statements should only be split into separate commands when consolidation is not possible due to dependencies (e.g., when later variables must reference earlier ones that need to be set first, or when PATH must be modified sequentially).

Applied to files:

components/package-template/src/sbin/admin-tools/dataset-manager.sh
components/package-template/src/sbin/.common-env.sh
components/package-template/src/sbin/stop-clp.sh
components/package-template/src/sbin/decompress.sh
components/package-template/src/sbin/admin-tools/archive-manager.sh
components/package-template/src/sbin/compress.sh
components/package-template/src/sbin/search.sh
components/package-template/src/sbin/start-clp.sh
components/package-template/src/sbin/compress-from-s3.sh

📚 Learning: 2025-07-07T17:43:04.349Z

Learnt from: jackluo923
Repo: y-scope/clp PR: 1054
File: components/core/tools/docker-images/clp-env-base-musllinux_1_2-aarch64/build.sh:3-5
Timestamp: 2025-07-07T17:43:04.349Z
Learning: In CLP project build scripts (specifically build.sh files in docker-images directories), maintain consistency with the established pattern of using separate `set -eu` and `set -o pipefail` commands rather than combining them into `set -euo pipefail`, to ensure uniform script structure across all platform build scripts.

Applied to files:

components/package-template/src/sbin/admin-tools/dataset-manager.sh
components/package-template/src/sbin/.common-env.sh
components/package-template/src/sbin/stop-clp.sh
components/package-template/src/sbin/decompress.sh
components/package-template/src/sbin/admin-tools/archive-manager.sh
components/package-template/src/sbin/compress.sh
components/package-template/src/sbin/search.sh
components/package-template/src/sbin/start-clp.sh
components/package-template/src/sbin/compress-from-s3.sh

📚 Learning: 2025-07-01T14:52:02.418Z

Learnt from: jackluo923
Repo: y-scope/clp PR: 1054
File: components/core/tools/docker-images/clp-env-base-musllinux_1_2-x86/build.sh:18-24
Timestamp: 2025-07-01T14:52:02.418Z
Learning: In the CLP project, consistency across platform build scripts is prioritized over defensive programming when it comes to git remote handling. All build.sh files in docker-images directories should follow the same pattern for git metadata injection.

Applied to files:

components/package-template/src/sbin/admin-tools/dataset-manager.sh
components/package-template/src/sbin/.common-env.sh
components/package-template/src/sbin/stop-clp.sh
components/package-template/src/sbin/admin-tools/archive-manager.sh
components/package-template/src/sbin/search.sh
components/package-template/src/sbin/start-clp.sh
components/package-template/src/sbin/compress-from-s3.sh

📚 Learning: 2025-07-01T14:51:19.172Z

Learnt from: jackluo923
Repo: y-scope/clp PR: 1054
File: components/core/tools/scripts/lib_install/musllinux_1_2/install-packages-from-source.sh:6-8
Timestamp: 2025-07-01T14:51:19.172Z
Learning: In CLP installation scripts within `components/core/tools/scripts/lib_install/`, maintain consistency with existing variable declaration patterns across platforms rather than adding individual improvements like `readonly` declarations.

Applied to files:

components/package-template/src/sbin/.common-env.sh
components/package-template/src/sbin/stop-clp.sh
components/package-template/src/sbin/start-clp.sh

📚 Learning: 2025-07-07T17:41:15.655Z

Learnt from: jackluo923
Repo: y-scope/clp PR: 1054
File: components/core/tools/scripts/lib_install/musllinux_1_2/install-prebuilt-packages.sh:27-32
Timestamp: 2025-07-07T17:41:15.655Z
Learning: In CLP installation scripts, consistency across platform scripts is prioritized over defensive programming improvements. For example, when extracting Task binaries with tar in `install-prebuilt-packages.sh`, the extraction pattern should remain consistent with other platform scripts rather than adding defensive flags like `--strip-components=1` to handle potential tarball layout changes.

Applied to files:

components/package-template/src/sbin/decompress.sh
components/package-template/src/sbin/start-clp.sh
components/package-template/src/sbin/compress-from-s3.sh

📚 Learning: 2025-07-23T09:54:45.185Z

Learnt from: Bill-hbrhbr
Repo: y-scope/clp PR: 1122
File: components/core/src/clp/clp/CMakeLists.txt:175-195
Timestamp: 2025-07-23T09:54:45.185Z
Learning: In the CLP project, when reviewing CMakeLists.txt changes that introduce new compression library dependencies (BZip2, LibLZMA, LZ4, ZLIB), the team prefers to address conditional linking improvements in separate PRs rather than expanding the scope of focused migration PRs like the LibArchive task-based installation migration.

Applied to files:

components/package-template/src/sbin/decompress.sh
components/package-template/src/sbin/compress.sh
components/package-template/src/sbin/compress-from-s3.sh

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)

GitHub Check: package-image
GitHub Check: lint-check (ubuntu-24.04)
GitHub Check: lint-check (macos-15)

🔇 Additional comments (9)

components/package-template/src/sbin/.common-env.sh (1)

72-75: Non-interactive flag mechanism looks solid.

The array initialization, non-interactive shell detection via $- parameter, and conditional flag append all follow bash idioms correctly. Placement after Docker plugin/socket resolution is logical.

components/package-template/src/sbin/admin-tools/dataset-manager.sh (1)

13-14: Array expansion follows correct bash syntax and Docker Compose conventions.

The "${CLP_COMPOSE_RUN_EXTRA_FLAGS[@]}" expansion places each array element as a separate argument, correctly positioned after --rm and before the service name. Expansion to empty string when the array is empty is handled properly by the shell.

components/package-template/src/sbin/compress.sh (1)

13-14: Pattern consistent with other sbin scripts.

Flags injection follows the same approach as other scripts in this PR. Array is available from sourced .common-env.sh and expanded correctly in the docker compose command.

components/package-template/src/sbin/admin-tools/archive-manager.sh (1)

13-14: Consistent flag injection pattern maintained.

Array expansion and docker compose invocation structure match other sbin scripts. Relative path to .common-env.sh is correctly adjusted for subdirectory location.

components/package-template/src/sbin/stop-clp.sh (1)

13-14: Consistent with established pattern across sbin scripts.

Array expansion and docker compose invocation follow the same structure as other scripts. Variable scoping from sourced .common-env.sh is correct.

components/package-template/src/sbin/search.sh (1)

13-14: Pattern consistent with other sbin scripts in this PR.

Array expansion and docker compose command structure match established convention across all modified scripts.

components/package-template/src/sbin/compress-from-s3.sh (1)

13-14: Consistent application of flag injection pattern.

Docker compose invocation follows established structure across all sbin scripts in this PR.

components/package-template/src/sbin/decompress.sh (1)

13-14: Consistent pattern applied across all sbin scripts.

Array injection into docker compose command is correctly implemented. All scripts follow identical structure for sourcing and using CLP_COMPOSE_RUN_EXTRA_FLAGS.

components/package-template/src/sbin/start-clp.sh (1)

13-14: Proper bash array expansion with correct docker compose flag placement.

The modification correctly injects CLP_COMPOSE_RUN_EXTRA_FLAGS using the proper bash idiom "${CLP_COMPOSE_RUN_EXTRA_FLAGS[@]}" to expand the array, and the flags are positioned after run --rm and before the service name, which is the correct location in the docker compose command syntax.

Please confirm that .common-env.sh properly initializes CLP_COMPOSE_RUN_EXTRA_FLAGS as an array and that this file is consistently updated across all affected sbin scripts (compress.sh, decompress.sh, search.sh, stop-clp.sh, etc.) as described in the PR objectives.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

junhaoliao · 2025-11-06T23:41:38Z

-    stdin_open: true
-    tty: true


These lines are removed to avoid confusions. No matter what values we set here, they would only affect command like docker compose up but not docker compose run.

Reference:
Here's the source code of docker compose run
https://github.com/docker/compose/blob/c37ede62dbb6485c4d5e297db9134631e9b2095e/cmd/compose/run.go#L88-L89

… scripts non-interactively (fixes y-scope#1566). (y-scope#1567)

fix(clp-package): Disable Docker interactive mode when running sbin…

3b2876b

… scripts non-interactively (fixes y-scope#1566).

junhaoliao requested a review from a team as a code owner November 6, 2025 23:40

junhaoliao commented Nov 6, 2025

View reviewed changes

kirkrodrigues approved these changes Nov 7, 2025

View reviewed changes

junhaoliao merged commit 0d87904 into y-scope:main Nov 7, 2025
21 checks passed

junhaoliao deleted the detach-stdin branch November 7, 2025 16:01

This was referenced May 9, 2026

sbin scripts disable interactive stdin for foreground terminal runs #2266

Closed

fix(clp-package): Enable Docker interactive mode for foreground terminal runs (fixes #2266). #2267

Merged

junhaoliao added a commit to junhaoliao/clp that referenced this pull request May 17, 2026

fix(clp-package): Disable Docker interactive mode when running sbin…

985c7a2

… scripts non-interactively (fixes y-scope#1566). (y-scope#1567)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(clp-package): Disable Docker interactive mode when running `sbin` scripts non-interactively (fixes #1566).#1567

fix(clp-package): Disable Docker interactive mode when running `sbin` scripts non-interactively (fixes #1566).#1567
junhaoliao merged 1 commit into
y-scope:mainfrom
junhaoliao:detach-stdin

junhaoliao commented Nov 6, 2025 •

edited by coderabbitai Bot

Loading

Uh oh!

coderabbitai Bot commented Nov 6, 2025 •

edited

Loading

Uh oh!

junhaoliao Nov 6, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

junhaoliao commented Nov 6, 2025 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Problem

Solution

Checklist

Validation performed

Summary by CodeRabbit

Release Notes

Uh oh!

coderabbitai Bot commented Nov 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Pre-merge checks and finishing touches

Uh oh!

junhaoliao Nov 6, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

junhaoliao commented Nov 6, 2025 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented Nov 6, 2025 •

edited

Loading