Skip to content

fix(clp-package): Use host networking for the sbin script containers (fixes #1560).#1563

Merged
junhaoliao merged 1 commit into
y-scope:mainfrom
junhaoliao:runtime-host-network
Nov 6, 2025
Merged

fix(clp-package): Use host networking for the sbin script containers (fixes #1560).#1563
junhaoliao merged 1 commit into
y-scope:mainfrom
junhaoliao:runtime-host-network

Conversation

@junhaoliao

@junhaoliao junhaoliao commented Nov 5, 2025 •
edited by coderabbitai Bot
Loading

Copy link
Copy Markdown
Member

Description

As the title says

Checklist

  • The PR satisfies the contribution guidelines.
  • This is a breaking change and that has been indicated in the PR title, OR this isn't a
    breaking change.
  • Necessary docs have been updated, OR no docs need to be updated.

Validation performed

Edited etc/clp-config.yaml and changed database.host to a non localhost address:

database:
  type: "mariadb"  # "mariadb" or "mysql"
  host: "10.1.0.22"
  port: 3306
  name: "clp-db"

Ran ./sbin/start-clp.sh and observed the project was started successfully.

Summary by CodeRabbit

  • Chores
    • Updated deployment network configuration for the runtime service.

@junhaoliao junhaoliao requested a review from a team as a code owner November 5, 2025 23:35
@coderabbitai

coderabbitai Bot commented Nov 5, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Walkthrough

The change adds network_mode: "host" to the clp-runtime service in docker-compose.runtime.yaml to enable host networking mode for the runtime service container.

Changes

Cohort / File(s) Change Summary
Network configuration update
tools/deployment/package/docker-compose.runtime.yaml		 Add network_mode: "host" to clp-runtime service to enable host network connectivity

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

This is a single-line configuration change with no logic modifications or structural alterations.

Possibly related issues

Pre-merge checks and finishing touches

✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and specifically describes the main change: adding host networking to the CLP runtime container. It follows Conventional Commits format and directly relates to the changeset.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

kirkrodrigues
kirkrodrigues approved these changes Nov 6, 2025
View reviewed changes

@kirkrodrigues kirkrodrigues left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the PR title, how about:

fix(clp-package): Use host networking for the `sbin` script containers (fixes #1560).

@junhaoliao junhaoliao changed the title fix(clp-package): Set network mode to host in the CLP runtime container (fixes #1560). For the PR title, how about: fix(clp-package): Use host networking for the sbin script containers (fixes #1560). Nov 6, 2025
@junhaoliao junhaoliao changed the title For the PR title, how about: fix(clp-package): Use host networking for the sbin script containers (fixes #1560). fix(clp-package): Use host networking for the sbin script containers (fixes #1560). Nov 6, 2025
@junhaoliao junhaoliao merged commit 45c201d into y-scope:main Nov 6, 2025
21 of 23 checks passed
@junhaoliao junhaoliao deleted the runtime-host-network branch November 6, 2025 05:54
junhaoliao added a commit to junhaoliao/clp that referenced this pull request May 17, 2026
@junhaoliao
fix(clp-package): Use host networking for the sbin script containers (
d746f2f 
fixes y-scope#1560). (y-scope#1563)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kirkrodrigues kirkrodrigues kirkrodrigues approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@junhaoliao @kirkrodrigues