feat(webui): Increase precision of time range in guided UI from seconds to milliseconds. #1543
Merged
Conversation
Contributor
WalkthroughIntroduced a Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes
Pre-merge checks and finishing touches✅ Passed checks (2 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
hoophalab
requested changes
Nov 3, 2025
Contributor
There was a problem hiding this comment.
Looks good, but when zooming in to only one log event, the timeline shows a bar for that log event, but result table is empty. We probably also need to do the same thing for buildSearchQuery to fix this.
--- a/components/webui/client/src/sql-parser/index.ts
+++ b/components/webui/client/src/sql-parser/index.ts
@@ -104,7 +104,7 @@ const buildSearchQuery = ({
timestampKey,
}: BuildSearchQueryProps): string => {
let queryString = `SELECT ${selectItemList} FROM ${databaseName}
-WHERE to_unixtime(${timestampKey}) BETWEEN ${startTimestamp.unix()} AND ${endTimestamp.unix()}`;
+WHERE to_unixtime(${timestampKey}) BETWEEN ${startTimestamp.valueOf() / MILLISECONDS_PER_SECOND} AND ${endTimestamp.valueOf() / MILLISECONDS_PER_SECOND}`;
added 2 commits
November 3, 2025 20:08
Contributor
Author
|
Okay good catch, i made change there as well |
hoophalab
approved these changes
Nov 3, 2025
junhaoliao
approved these changes
Nov 4, 2025
junhaoliao
left a comment
Member
There was a problem hiding this comment.
deferring to @hoophalab 's review
junhaoliao
pushed a commit
to junhaoliao/clp
that referenced
this pull request
May 17, 2026
…ds to milliseconds. (y-scope#1543)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I noticed a small issue where the total results displayed in ui was slightly lower than the amount ingested when running query with "all time". I believe this is due to a quirk of dayJS.unix() where it floors the timestamp to the nearest second. This PR replaces it with dayJS.valueOf() which includes milliseconds, and now the total results matches logs ingested.
Checklist
breaking change.
Validation performed
All time shows 1M results instead of slightly less than 1M with "all time"
Summary by CodeRabbit