Reviewing files that changed from the base of the PR and between 5c0a903 and e34e6de.

• Cargo.lock is excluded by !**/*.lock

• components/clp-rust-utils/Cargo.toml (1 hunks)
• components/clp-rust-utils/src/database.rs (1 hunks)
• components/clp-rust-utils/src/database/mysql.rs (1 hunks)
• components/clp-rust-utils/src/error.rs (1 hunks)
• components/clp-rust-utils/src/job_config.rs (1 hunks)
• components/clp-rust-utils/src/job_config/search.rs (1 hunks)
• components/clp-rust-utils/src/lib.rs (1 hunks)
• components/clp-rust-utils/src/package_config.rs (1 hunks)
• components/clp-rust-utils/src/package_config/config.rs (1 hunks)
• components/clp-rust-utils/src/package_config/credentials.rs (1 hunks)

• GitHub Check: package-image
• GitHub Check: rust-checks (ubuntu-22.04)
• GitHub Check: lint-check (ubuntu-24.04)
• GitHub Check: rust-checks (ubuntu-24.04)

components/clp-rust-utils/src/database.rs (1)

1-1: LGTM!

Clean module declaration following Rust conventions.

components/clp-rust-utils/src/lib.rs (2)

2-2: LGTM!

Appropriately exposes the new database module as part of the public API.

---

5-5: LGTM!

Appropriately exposes the new package_config module as part of the public API.

components/clp-rust-utils/src/database/mysql.rs (2)

25-30: Verify MySqlConnectOptions configuration is complete.

The current implementation sets the core connection parameters. If additional options (ssl, compression, autocommit) are added to DatabaseConfig, ensure they are properly applied here. For example:

let mut mysql_options = sqlx::mysql::MySqlConnectOptions::new()
    .host(&config.host)
    .port(config.port)
    .database(&config.name)
    .username(&credentials.user)
    .password(credentials.password.expose_secret());

// Apply optional SSL certificate if configured
if let Some(ref ssl_cert) = config.ssl_cert {
    mysql_options = mysql_options.ssl_ca(ssl_cert);
}

---

8-19: Documentation looks good.

The function documentation clearly describes the return value and error conditions. The reference to sqlx::mysql::MySqlPoolOptions::connect_with in the errors section is helpful.

components/clp-rust-utils/src/error.rs (1)

11-12: LGTM!

The SqlxError variant follows the existing error handling pattern and properly enables automatic error conversion from sqlx::Error using the #[from] attribute. This integrates well with the create_mysql_pool function's error handling.

components/clp-rust-utils/src/job_config.rs (1)

4-5: Code changes are approved.

The search.rs module exists and contains appropriate public exports (constants, types, structs, and enums). The module re-export pattern follows standard Rust conventions and is correctly integrated into job_config.rs.

components/clp-rust-utils/src/package_config.rs (2)

3-3: No issues found—the Config re-export is valid.

Verification confirms that config.rs exists and defines the Config struct (lines 4–13) with the Database field (line 17) that the re-export assumes. The type is properly structured and available for use in mysql.rs.

---

1-7: Default paths are correct and consistent with CLP package conventions.

Verification confirms that "etc/clp-config.yml" and "etc/credentials.yml" match the default paths used throughout the CLP package (e.g., components/clp-py-utils/clp_py_utils/clp_config.py and deployment scripts). The module structure follows Rust conventions and the paths align with existing CLP configuration standards.

components/clp-rust-utils/Cargo.toml (2)

15-15: No issues detected — dependency version is current and secure.

✓ sqlx 0.8.6 is the latest stable version
✓ No security vulnerabilities affect this version (advisory applies only to versions ≤ 0.8.0)
✓ Cargo.lock has been updated and is in sync with the workspace configuration

---

11-15: Cargo.lock has been updated correctly; however, fix the Rust edition.

All new dependencies (num_enum 0.7.5, rmp-serde 1.3.0, secrecy 0.10.3, serde 1.0.228, sqlx 0.8.6) are present in Cargo.lock with correct versions and no unintended changes to other packages.

However, components/clp-rust-utils/Cargo.toml specifies edition = "2024", which is not a valid Rust edition. Valid editions are 2015, 2018, and 2021. This will prevent compilation. Update to a valid edition.

⛔ Skipped due to learnings

Learnt from: junhaoliao
Repo: y-scope/clp PR: 0
File: :0-0
Timestamp: 2025-10-22T21:01:31.391Z
Learning: In y-scope/clp, for the clp-rust-checks workflow (GitHub Actions) and the Taskfile target deps:lock:check-rust, we should verify Rust Cargo.lock is in sync with Cargo.toml using a non-mutating method (e.g., cargo metadata --locked / cargo check --locked) to keep CI deterministic and avoid updating dependencies during validation.

Learnt from: junhaoliao
Repo: y-scope/clp PR: 0
File: :0-0
Timestamp: 2025-10-22T21:02:31.113Z
Learning: Repository y-scope/clp: Maintain deterministic CI/builds for Rust; add a check to verify Cargo.lock is in sync with Cargo.toml without updating dependencies (non-mutating verification in clp-rust-checks workflow).

Learnt from: LinZhihao-723
Repo: y-scope/clp PR: 1448
File: components/clp-rust-utils/Cargo.toml:4-4
Timestamp: 2025-10-20T22:20:45.733Z
Learning: Rust edition 2024 is a valid edition value in Cargo.toml files. It was released with Rust 1.85 on February 20, 2025.

Reviewing files that changed from the base of the PR and between 1f41bf4 and 2427d9b.

• Cargo.lock is excluded by !**/*.lock

• components/clp-rust-utils/src/clp_config.rs (1 hunks)
• components/clp-rust-utils/src/clp_config/package.rs (0 hunks)
• components/clp-rust-utils/src/database/mysql.rs (1 hunks)
• components/clp-rust-utils/src/error.rs (1 hunks)
• components/clp-rust-utils/src/lib.rs (1 hunks)

• components/clp-rust-utils/src/clp_config/package.rs

• GitHub Check: package-image
• GitHub Check: rust-checks (ubuntu-24.04)
• GitHub Check: rust-checks (ubuntu-22.04)
• GitHub Check: rust-checks (macos-15)
• GitHub Check: lint-check (macos-15)

components/clp-rust-utils/src/lib.rs (1)

2-2: LGTM!

The addition of the database module appropriately expands the public API surface to expose the new MySQL connection pool functionality.

components/clp-rust-utils/src/clp_config.rs (1)

1-1: Verify that the breaking API change is documented.

Changing the package module visibility to public and removing the wildcard re-export (pub use package::*;) is a breaking change. Users who previously accessed types like Config directly from clp_config will now need to use the full path clp_config::package::config::Config.

Ensure this breaking change is documented in the PR description, changelog, or migration guide.

components/clp-rust-utils/src/error.rs (2)

6-9: Document the breaking changes from error variant renames.

The renames (MsgpackEncodeError → MsgpackEncode, IoError → Io) improve consistency with Rust conventions by removing the redundant "Error" suffix. However, these are breaking changes for any code that pattern-matches on these variants.

Ensure these breaking changes are documented alongside the API changes in clp_config.rs.

---

11-12: LGTM!

The new Sqlx error variant correctly enables automatic conversion from sqlx::Error to crate::Error, supporting error propagation in the new database module.

components/clp-rust-utils/src/database/mysql.rs (1)

1-6: LGTM!

The imports are correct and follow security best practices by using ExposeSecret from the secrecy crate to safely handle password credentials.