Skip to content

fix(clp-package): Update mcp_server config in etc/clp-config.yml to match defaults in CLPConfig.#1515

Merged
rishikeshdevsot merged 2 commits into
y-scope:mainfrom
rishikeshdevsot:config-update
Oct 28, 2025
Merged

fix(clp-package): Update mcp_server config in etc/clp-config.yml to match defaults in CLPConfig.#1515
rishikeshdevsot merged 2 commits into
y-scope:mainfrom
rishikeshdevsot:config-update

Conversation

@rishikeshdevsot

@rishikeshdevsot rishikeshdevsot commented Oct 28, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Description

The current default configuration for mcp-server in clp-config.yml is:

#mcp-server:
# host: "localhost"
# port: 8000
# logging_level: "INFO"

which does not respect the default specification in CLPConfig which is None.
This PR changes the default to:

#mcp-server: null

making the default configuration for mcp-server consistent with the default configuration in CLPConfig.

The defaults of etc/clp-config.yml and CLPConfig need to be consistent, since a fully commented etc/clp-config.yml makes the CLP package use CLPConfig’s defaults
Thus, this PR makes CLP Package's behaviour when etc/clp-config.yml is uncommented (but unmodified) to be same as when etc/clp-config.yml is left commented.

Checklist

  • The PR satisfies the contribution guidelines.
  • This is a breaking change and that has been indicated in the PR title, OR this isn't a
    breaking change.
  • Necessary docs have been updated, OR no docs need to be updated.

Validation performed

Summary by CodeRabbit

Release Notes

  • Chores
    • Updated server configuration settings to disable a backend service component.

@coderabbitai

coderabbitai Bot commented Oct 28, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Walkthrough

The mcp_server configuration in the CLP config template is updated by replacing a commented-out configuration block containing host, port, and logging_level properties with a single null assignment, effectively disabling the mcp_server configuration.

Changes

Cohort / File(s) Change Summary
Configuration Updates
components/package-template/src/etc/clp-config.yml		 Replaces commented-out mcp_server configuration block with mcp_server: null to disable the mcp_server configuration

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

  • Single configuration file modified
  • Straightforward change from commented block to null assignment
  • No logic or structural changes involved

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. You can run @coderabbitai generate docstrings to improve docstring coverage.
✅ Passed checks (2 passed)
Check name Status Explanation
Title Check ✅ Passed The pull request title "feat(clp-config): Change default configuration for mcp-server to be null" directly and accurately describes the primary change in the changeset. The title identifies both the component (clp-config) and the specific modification (changing mcp-server default configuration to null), which aligns perfectly with the raw summary showing the replacement of a commented mcp_server block with a null value. The title is concise, specific, and clearly communicates the main intent of the changeset without being vague or misleading.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@rishikeshdevsot rishikeshdevsot marked this pull request as ready for review October 28, 2025 18:51
@rishikeshdevsot rishikeshdevsot requested a review from a team as a code owner October 28, 2025 18:51
kirkrodrigues
kirkrodrigues approved these changes Oct 28, 2025
View reviewed changes

@kirkrodrigues kirkrodrigues left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the PR title, how about:

fix(clp-package): Update `mcp_server` config in `etc/clp-config.yml` to match defaults in `CLPConfig`.

Similarly, it's worth updating the PR description to indicate that the reason for the change is because etc/clp-config.yml didn't respect the defaults specified in CLPConfig. When the etc/clp-config.yml is fully commented, the CLP package will use the defaults from CLPConfig. When etc/clp-config.yml is uncommented, we want the CLP package's behaviour to remain identical (unless, of course, the user changes some config).

rishikeshdevsot added a commit to rishikeshdevsot/clp that referenced this pull request Oct 28, 2025
@rishikeshdevsot
docs: updated docs to match new config in y-scope#1515
a248266
@rishikeshdevsot rishikeshdevsot merged commit e0dbed5 into y-scope:main Oct 28, 2025
24 checks passed
@rishikeshdevsot rishikeshdevsot changed the title feat(clp-config): Change default configuration for mcp-server to be null fix(clp-package): Update mcp_server config in etc/clp-config.yml to match defaults in CLPConfig. Oct 28, 2025
@rishikeshdevsot

rishikeshdevsot commented Oct 28, 2025

Copy link
Copy Markdown
Contributor Author

For the PR title, how about:

fix(clp-package): Update `mcp_server` config in `etc/clp-config.yml` to match defaults in `CLPConfig`.

Similarly, it's worth updating the PR description to indicate that the reason for the change is because etc/clp-config.yml didn't respect the defaults specified in CLPConfig. When the etc/clp-config.yml is fully commented, the CLP package will use the defaults from CLPConfig. When etc/clp-config.yml is uncommented, we want the CLP package's behaviour to remain identical (unless, of course, the user changes some config).

addressed.

junhaoliao pushed a commit to junhaoliao/clp that referenced this pull request May 17, 2026
@rishikeshdevsot
feat(clp-config): Change default configuration for mcp-server to be n…
ac472aa 
…ull (y-scope#1515)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kirkrodrigues kirkrodrigues kirkrodrigues approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@rishikeshdevsot @kirkrodrigues