Skip to content

feat(webui): Enable guided mode for Presto Web UI.#1490

Merged
davemarco merged 4 commits into
y-scope:mainfrom
davemarco:enableguided
Oct 27, 2025
Merged

feat(webui): Enable guided mode for Presto Web UI.#1490
davemarco merged 4 commits into
y-scope:mainfrom
davemarco:enableguided

Conversation

@davemarco

@davemarco davemarco commented Oct 24, 2025 •
edited by coderabbitai Bot
Loading

Copy link
Copy Markdown
Contributor

Description

Enables guided mode in package by default. Before was only available for dev

Checklist

  • The PR satisfies the contribution guidelines.
  • This is a breaking change and that has been indicated in the PR title, OR this isn't a
    breaking change.
  • Necessary docs have been updated, OR no docs need to be updated.

Validation performed

TBD after presto fix

Summary by CodeRabbit

  • New Features

    • SQL interface button is now always available in the search UI (no conditional gating).

  • Changes

    • Default search mode now starts in the guided interface.

  • Chores

    • Removed legacy guided startup script from the client package.

@coderabbitai

coderabbitai Bot commented Oct 24, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Walkthrough

Removed the feature-flag gate so the SQL interface button is always rendered, changed the default Presto search state's SQL interface from FREEFORM to GUIDED, and removed the "guided" npm script from the web UI client package.json.

Changes

Cohort / File(s) Change Summary
Package Script Cleanup
components/webui/client/package.json		 Removed the guided npm script from the scripts section.
SQL Interface UI Modifications
components/webui/client/src/pages/SearchPage/SearchControls/Presto/FreeformControls.tsx		 Deleted the isGuidedEnabled feature-flag usage and replaced conditional rendering {isGuidedEnabled && <SqlInterfaceButton/>} with unconditional <SqlInterfaceButton/>.
Default State Configuration
components/webui/client/src/pages/SearchPage/SearchState/Presto/index.tsx		 Changed default PRESTO_SEARCH_STATE_DEFAULT.sqlInterface from PRESTO_SQL_INTERFACE.FREEFORM to PRESTO_SQL_INTERFACE.GUIDED.

Sequence Diagram(s)

sequenceDiagram
  autonumber
  participant User
  participant UI as SearchPage UI
  participant State as Presto Search State

  Note right of UI #D6EAF8: On render (after this change)
  User->>UI: opens SearchPage
  UI->>UI: render SqlInterfaceButton (always)
  UI->>State: read PRESTO_SEARCH_STATE_DEFAULT.sqlInterface
  Note right of State #F5EEF8: Default now GUIDED
  State-->>UI: sqlInterface = GUIDED
  UI-->>User: show UI with SqlInterfaceButton and GUIDED default
Loading

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

  • Pay attention to UI rendering changes and any places that previously relied on the feature flag.
  • Verify downstream components/readers of sqlInterface handle GUIDED as the default.
  • Confirm removal of the guided npm script doesn't affect developer workflows or CI scripts.

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. You can run @coderabbitai generate docstrings to improve docstring coverage.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check ✅ Passed The pull request title "feat(webui): Enable guided mode for Presto Web UI." clearly and accurately summarizes the main objective of the changeset. The three key modifications across the files—removing the "guided" npm script, removing the feature-flag gating from the SQL interface button, and changing the default SQL interface state from FREEFORM to GUIDED—all work in concert to achieve the stated objective of enabling guided mode by default. The title is concise, uses appropriate conventional commit formatting, and provides sufficient clarity for reviewers scanning the pull request history to immediately understand the primary change.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@davemarco davemarco requested a review from hoophalab October 27, 2025 15:35
@davemarco davemarco marked this pull request as ready for review October 27, 2025 15:35
@davemarco davemarco requested a review from a team as a code owner October 27, 2025 15:35
@hoophalab

hoophalab commented Oct 27, 2025

Copy link
Copy Markdown
Contributor

how about

feat(webui): Enable guided mode for Presto Web UI.

@davemarco davemarco changed the title feat(webui): Enable guided mode for presto webui. feat(webui): Enable guided mode for Presto Web UI. Oct 27, 2025
junhaoliao
junhaoliao reviewed Oct 27, 2025
View reviewed changes

@junhaoliao junhaoliao left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

deferring to @hoophalab 's review

@davemarco davemarco merged commit 69fbe45 into y-scope:main Oct 27, 2025
19 checks passed
junhaoliao pushed a commit to junhaoliao/clp that referenced this pull request May 17, 2026
@davemarco
feat(webui): Enable guided mode for Presto Web UI. (y-scope#1490)
a81284e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@junhaoliao junhaoliao junhaoliao approved these changes

@hoophalab hoophalab hoophalab approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@davemarco @hoophalab @junhaoliao