Skip to content

fix(build): Add missing Spider scheduler and worker binaries to task package's source list (fixes #1409).#1416

Merged
sitaowang1998 merged 1 commit into
y-scope:mainfrom
sitaowang1998:spider-source
Oct 14, 2025
Merged

fix(build): Add missing Spider scheduler and worker binaries to task package's source list (fixes #1409).#1416
sitaowang1998 merged 1 commit into
y-scope:mainfrom
sitaowang1998:spider-source

Conversation

@sitaowang1998

@sitaowang1998 sitaowang1998 commented Oct 13, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Description

This PR resolves #1409 by adding spider_scheduler and spider_worker to the package task's sources list, so the package will rerun if either executable changes.

Checklist

  • The PR satisfies the contribution guidelines.
  • This is a breaking change and that has been indicated in the PR title, OR this isn't a
    breaking change.
  • Necessary docs have been updated, OR no docs need to be updated.

Validation performed

  • Modify either executable triggers package task.

Summary by CodeRabbit

  • New Features

    • The package now includes Spider Scheduler and Spider Worker components, making these modules available after installation and deployment.

  • Chores

    • Updated packaging to assemble and generate checksums for the new Spider components, ensuring they are included in distribution artefacts with consistent integrity verification.

@sitaowang1998 sitaowang1998 marked this pull request as ready for review October 13, 2025 21:49
@sitaowang1998 sitaowang1998 requested a review from a team as a code owner October 13, 2025 21:49
@coderabbitai

coderabbitai Bot commented Oct 13, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Walkthrough

Added two new build sources, spider_scheduler and spider_worker, to the package assembly in taskfile.yaml, extending package contents and checksum generation to include these Spider components.

Changes

Cohort / File(s) Summary of Changes
Packaging: Taskfile updates
taskfile.yaml		 Included G_SPIDER_BUILD_DIR/spider-build/src/spider/spider_scheduler and .../spider_worker as package sources and in checksum generation to track Spider artifacts in packaging.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related issues

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check ✅ Passed The title clearly and succinctly describes the primary change by stating the build fix and specifying that missing Spider scheduler and worker binaries are added to the package task’s source list, while also referencing the relevant issue number.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

junhaoliao
junhaoliao approved these changes Oct 14, 2025
View reviewed changes

@junhaoliao junhaoliao left a comment •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Just to show that we've considered this alternative -) one option is to have deps:spider generate a checksum file, which the package task could then reference as a single source instead of listing individual binaries. This approach might depend on the work in #1415.

Personally, I find the current approach in this PR cleaner - explicitly adding the binaries to the source list keeps the package task relatively self-contained and easier to reason about.

For the title, how about:

fix(build): Add missing Spider scheduler and worker binaries to task `package`'s source list (fixes #1409).

@Bill-hbrhbr

Bill-hbrhbr commented Oct 14, 2025

Copy link
Copy Markdown
Contributor

@junhaoliao What about spider_task_executor?

@sitaowang1998 sitaowang1998 changed the title fix(build): Add spider executables to package sources. fix(build): Add missing Spider scheduler and worker binaries to task package's source list (fixes #1409). Oct 14, 2025
@sitaowang1998

sitaowang1998 commented Oct 14, 2025

Copy link
Copy Markdown
Contributor Author

@junhaoliao What about spider_task_executor?

spider_task_executor is not used in clp right now.

@sitaowang1998 sitaowang1998 merged commit 77b122c into y-scope:main Oct 14, 2025
33 of 35 checks passed
@sitaowang1998 sitaowang1998 deleted the spider-source branch October 14, 2025 13:45
junhaoliao pushed a commit to junhaoliao/clp that referenced this pull request May 17, 2026
@sitaowang1998
fix(build): Add missing Spider scheduler and worker binaries to task …
1f63b7b 
…`package`'s source list (fixes y-scope#1409). (y-scope#1416)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@junhaoliao junhaoliao junhaoliao approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add checksum tracking for spider artifacts in package task

3 participants

@sitaowang1998 @Bill-hbrhbr @junhaoliao