Skip to content

feat(webui): Display full dataset names in the dataset selector popup.#1400

Merged
hoophalab merged 2 commits into
y-scope:mainfrom
hoophalab:long-dataset
Oct 10, 2025
Merged

feat(webui): Display full dataset names in the dataset selector popup.#1400
hoophalab merged 2 commits into
y-scope:mainfrom
hoophalab:long-dataset

Conversation

@hoophalab

@hoophalab hoophalab commented Oct 9, 2025 •
edited by junhaoliao
Loading

Copy link
Copy Markdown
Contributor

Description

Long dataset names were being clipped in the dataset selector popup, making them difficult to read. This PR fixes this issue.

long

Checklist

  • The PR satisfies the contribution guidelines.
  • This is a breaking change and that has been indicated in the PR title, OR this isn't a
    breaking change.
  • Necessary docs have been updated, OR no docs need to be updated.

Validation performed

The popup matches dataset name width

Summary by CodeRabbit

  • Style
    • Updated the dataset selector dropdown so its popup no longer automatically matches the field width. The popup now sizes to its content, improving visibility of long dataset names and reducing truncation.
    • Prevents excessive empty space when options are narrow, enhancing layout responsiveness and readability.
    • No changes to selection behaviour or filtering. Affects the dataset control on the Search page.

@hoophalab hoophalab requested a review from a team as a code owner October 9, 2025 16:27
@hoophalab hoophalab requested a review from davemarco October 9, 2025 16:27
@coderabbitai

coderabbitai Bot commented Oct 9, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Walkthrough

A single UI change adds the prop popupMatchSelectWidth={false} to a Select in DatasetSelect.tsx, altering dropdown sizing behaviour. No other logic or control flow was modified.

Changes

Cohort / File(s) Summary
Web UI Select prop update
components/webui/client/src/pages/SearchPage/SearchControls/Dataset/DatasetSelect.tsx		 Added prop popupMatchSelectWidth={false} to the Select component to decouple popup width from the select’s width.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Title Check ✅ Passed The title clearly encapsulates the main change by stating that the dataset selector popup will now display full dataset names, directly reflecting the addition of the width-adjusting prop.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

davemarco
davemarco approved these changes Oct 9, 2025
View reviewed changes

@davemarco davemarco left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@hoophalab hoophalab requested a review from junhaoliao October 9, 2025 18:49
junhaoliao
junhaoliao approved these changes Oct 10, 2025
View reviewed changes

@junhaoliao junhaoliao left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

deferring to @davemarco 's review

@hoophalab hoophalab merged commit 2e5ab12 into y-scope:main Oct 10, 2025
23 of 24 checks passed
@hoophalab hoophalab deleted the long-dataset branch October 23, 2025 19:06
junhaoliao pushed a commit to junhaoliao/clp that referenced this pull request May 17, 2026
@hoophalab
feat(webui): Display full dataset names in the dataset selector popup. (
a5e22fa 
y-scope#1400)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@junhaoliao junhaoliao junhaoliao approved these changes

@davemarco davemarco davemarco approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@hoophalab @junhaoliao @davemarco