Skip to content

chore(presto-clp): Expose Presto coordinator container port 8080 to host 8889 (resolves #1264).#1265

Merged
anlowee merged 2 commits into
y-scope:mainfrom
anlowee:xwei/expose-8080
Aug 25, 2025
Merged

chore(presto-clp): Expose Presto coordinator container port 8080 to host 8889 (resolves #1264).#1265
anlowee merged 2 commits into
y-scope:mainfrom
anlowee:xwei/expose-8080

Conversation

@anlowee

@anlowee anlowee commented Aug 25, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Description

This PR resolves #1264 .

Checklist

  • The PR satisfies the contribution guidelines.
  • This is a breaking change and that has been indicated in the PR title, OR this isn't a
    breaking change.
  • Necessary docs have been updated, OR no docs need to be updated.

Validation performed

Passed the CI.
Tried ssh -L8889:localhost:8889 user@host to access the UI locally.

@anlowee anlowee requested a review from a team as a code owner August 25, 2025 17:30
@coderabbitai

coderabbitai Bot commented Aug 25, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Warning

Rate limit exceeded

@anlowee has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 20 minutes and 46 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between 7f6bb6d and 112a02c.

📒 Files selected for processing (1)
  • tools/deployment/presto-clp/docker-compose.yaml (1 hunks)
✨ Finishing Touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

  • Visit our Status Page to check the current availability of CodeRabbit.
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@kirkrodrigues kirkrodrigues changed the title chore: Expose Presto coordinator container port 8080 to host 8889 (resolves #1264). chore(presto-clp): Expose Presto coordinator container port 8080 to host 8889 (resolves #1264). Aug 25, 2025
kirkrodrigues
kirkrodrigues approved these changes Aug 25, 2025
View reviewed changes

@kirkrodrigues kirkrodrigues left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Edited the PR title directly.

@anlowee anlowee merged commit e807ffe into y-scope:main Aug 25, 2025
8 checks passed
junhaoliao pushed a commit to junhaoliao/clp that referenced this pull request May 17, 2026
@anlowee
chore(presto-clp): Expose Presto coordinator container port 8080 to h…
fcc2b24 
…ost 8889 (resolves y-scope#1264). (y-scope#1265)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kirkrodrigues kirkrodrigues kirkrodrigues approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Make presto coordinator reachable outside of docker container

2 participants

@anlowee @kirkrodrigues