Skip to content

refactor(glt): Remove duplicated clp::string_utils library from glt.#1101

Merged
gibber9809 merged 2 commits into
y-scope:mainfrom
gibber9809:delete-glt-string-utils
Jul 15, 2025
Merged

refactor(glt): Remove duplicated clp::string_utils library from glt.#1101
gibber9809 merged 2 commits into
y-scope:mainfrom
gibber9809:delete-glt-string-utils

Conversation

@gibber9809

@gibber9809 gibber9809 commented Jul 14, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Description

GLT currently has a slightly out of date copy of clp::string_utils in its source tree. Since the versions of clp::string_utils in both clp and glt are already set up as libraries with the same name, we simply delete the copy in glt and require no other changes.

We also remove the deleted files from the exceptions list in taskfiles/lint.yaml.

Checklist

  • The PR satisfies the contribution guidelines.
  • This is a breaking change and that has been indicated in the PR title, OR this isn't a
    breaking change.
  • Necessary docs have been updated, OR no docs need to be updated.

Validation performed

  • Validated that build still succeeds
  • Validated that unit tests still pass

Summary by CodeRabbit

  • Refactor
    • Removed all string utility functions related to wildcard pattern matching, character replacement, and string-to-integer conversion.
  • Chores
    • Updated linting configuration to reflect the removal of string utility files.

@gibber9809 gibber9809 requested a review from a team as a code owner July 14, 2025 17:08
@coderabbitai

coderabbitai Bot commented Jul 14, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Walkthrough

All source files related to string utility functions within the components/core/src/glt/string_utils directory, including their CMake configuration, implementation, and header, have been deleted. Corresponding entries for these files were also removed from the linting exclusion list in the project's task configuration.

Changes

File(s) Change Summary
components/core/src/glt/string_utils/CMakeLists.txt Deleted the CMake configuration for building the string_utils library and its alias target.
components/core/src/glt/string_utils/string_utils.cpp,
string_utils.hpp		 Deleted all implementation and declarations of string utility functions, including wildcard matching utilities.
taskfiles/lint.yaml Removed string_utils.cpp and string_utils.hpp from the C++ lint exclude list.
📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 2a92184 and 92560d6.

📒 Files selected for processing (4)
  • components/core/src/glt/string_utils/CMakeLists.txt (0 hunks)
  • components/core/src/glt/string_utils/string_utils.cpp (0 hunks)
  • components/core/src/glt/string_utils/string_utils.hpp (0 hunks)
  • taskfiles/lint.yaml (0 hunks)
💤 Files with no reviewable changes (4)
  • components/core/src/glt/string_utils/CMakeLists.txt
  • components/core/src/glt/string_utils/string_utils.cpp
  • taskfiles/lint.yaml
  • components/core/src/glt/string_utils/string_utils.hpp
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (8)
  • GitHub Check: centos-stream-9-dynamic-linked-bins
  • GitHub Check: centos-stream-9-static-linked-bins
  • GitHub Check: ubuntu-jammy-dynamic-linked-bins
  • GitHub Check: ubuntu-jammy-static-linked-bins
  • GitHub Check: ubuntu-jammy-lint
  • GitHub Check: build-macos (macos-14, true)
  • GitHub Check: build-macos (macos-13, true)
  • GitHub Check: build-macos (macos-13, false)
✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@gibber9809 gibber9809 changed the title refactor(glt): Delete the copy of clp::string_utils in glt. refactor(glt): Delete the copy of the clp::string_utils library in glt. Jul 14, 2025
haiqi96
haiqi96 approved these changes Jul 14, 2025
View reviewed changes

@haiqi96 haiqi96 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Though our original plan is to not update GLT, I agree with this PR so that any changes/bug fixes we make to the string_utils can be reflected in GLT as well. It can also make things less confusing since currently the string_util in GLT has a clp namespace.

Tested with this PR locally and confirmed that GLT still builts.
Also searched for glt/string_utils and confirmed the only occurance is in the linter file. so I think this change can be merged.

@haiqi96

haiqi96 commented Jul 14, 2025

Copy link
Copy Markdown
Contributor

For title, how about
refactor(glt): Remove duplicated clp::string_utils library from glt.

@gibber9809 gibber9809 changed the title refactor(glt): Delete the copy of the clp::string_utils library in glt. refactor(glt): Remove duplicated clp::string_utils library from glt. Jul 15, 2025
kirkrodrigues
kirkrodrigues approved these changes Jul 15, 2025
View reviewed changes

@kirkrodrigues kirkrodrigues left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deferring to @haiqi96's review.

@gibber9809 gibber9809 merged commit 65dc855 into y-scope:main Jul 15, 2025
22 checks passed
junhaoliao pushed a commit to junhaoliao/clp that referenced this pull request May 17, 2026
@gibber9809
refactor(glt): Remove duplicated clp::string_utils library from glt. (
74271a2 
y-scope#1101)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kirkrodrigues kirkrodrigues kirkrodrigues approved these changes

+1 more reviewer

@haiqi96 haiqi96 haiqi96 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@gibber9809 @haiqi96 @kirkrodrigues