Skip to content

fix(webui): Remove stale DOM node caching which broke keypress-controlled scrolling.#1083

Merged
davemarco merged 4 commits into
y-scope:mainfrom
davemarco:virtFix
Jul 9, 2025
Merged

fix(webui): Remove stale DOM node caching which broke keypress-controlled scrolling.#1083
davemarco merged 4 commits into
y-scope:mainfrom
davemarco:virtFix

Conversation

@davemarco

@davemarco davemarco commented Jul 8, 2025 •
edited by coderabbitai Bot
Loading

Copy link
Copy Markdown
Contributor

Description

PR #972 added scroll functionality to virtual table. As part of review, we added ability to cache table ref as performance optimization. Didnt notice then that ref can reference a previous table, and not always the latest table, which breaks the scrolling functionality since it is scrolling the ref from a previous table.

This PR removes the ref.

Checklist

  • The PR satisfies the contribution guidelines.
  • This is a breaking change and that has been indicated in the PR title, OR this isn't a
    breaking change.
  • Necessary docs have been updated, OR no docs need to be updated.

Validation performed

Run a query, then tried to scroll, and scroll worked as expected. Previously, occasionally did not scroll.

Summary by CodeRabbit

  • Refactor
    • Improved the way the scroll node element is accessed during keyboard navigation for more consistent behaviour. No visible changes to end-users.

@coderabbitai

coderabbitai Bot commented Jul 8, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Walkthrough

The update modifies the VirtualTable component to remove the cached scroll node reference, opting instead to query the scroll node element from the container on every keydown event. The logic for keyboard navigation and scrolling remains unchanged.

Changes

File(s) Change Summary
components/webui/client/src/components/VirtualTable/index.tsx Removed scrollNodeRef; now queries scroll node directly on keydown.

Possibly related PRs

Suggested reviewers

  • junhaoliao
📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between f1979be and e60c0f6.

📒 Files selected for processing (1)
  • components/webui/client/src/components/VirtualTable/index.tsx (1 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
`**/*.{cpp,hpp,java,js,jsx,tpp,ts,tsx}`: - Prefer `false == ` rather than `!`.

**/*.{cpp,hpp,java,js,jsx,tpp,ts,tsx}: - Prefer false == <expression> rather than !<expression>.

⚙️ Source: CodeRabbit Configuration File

List of files the instruction was applied to:

  • components/webui/client/src/components/VirtualTable/index.tsx
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
  • GitHub Check: lint-check (ubuntu-latest)
  • GitHub Check: lint-check (macos-latest)
🔇 Additional comments (1)
components/webui/client/src/components/VirtualTable/index.tsx (1)

32-34: LGTM! Good fix for the scrolling issue.

Removing the cached scroll node reference and querying it fresh on each keydown event correctly addresses the issue where a stale cached reference could cause scrolling to fail intermittently. While this introduces a small performance overhead from the DOM query, it's a reasonable trade-off to ensure the scroll functionality always operates on the current table instance.

✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@davemarco davemarco marked this pull request as ready for review July 8, 2025 19:21
@davemarco davemarco requested a review from a team as a code owner July 8, 2025 19:21
@davemarco davemarco requested a review from junhaoliao July 8, 2025 19:21
junhaoliao
junhaoliao approved these changes Jul 8, 2025
View reviewed changes

@junhaoliao junhaoliao left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i was able to reproduce the issue and can confirm the issue is fixed after applying the changes in this PR

for the title, how about:

fix(webui): Remove stale DOM node caching which broke keypress-controlled scrolling.

@davemarco davemarco changed the title fix(webui): Avoid caching virtual table ref to fix scrolling issue. fix(webui): Remove stale DOM node caching which broke keypress-controlled scrolling. Jul 9, 2025
@davemarco davemarco merged commit c5b27e5 into y-scope:main Jul 9, 2025
8 checks passed
junhaoliao pushed a commit to junhaoliao/clp that referenced this pull request May 17, 2026
@davemarco
fix(webui): Remove stale DOM node caching which broke keypress-contro…
b3cd3e4 
…lled scrolling. (y-scope#1083)

Co-authored-by: Marco <david.marcovitch@yscope.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@junhaoliao junhaoliao junhaoliao approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@davemarco @junhaoliao