build(clp-package): Increase minimum Python version from 3.8 to 3.9 as Python 3.8 has reached end-of-life.#1076
Conversation
WalkthroughThe documentation and package configuration files were updated to increase the minimum required Python version from 3.8 to 3.9 across build, linting, multi-node deployment, quick-start instructions, and project metadata. No other requirements, instructions, or public entities were modified. Changes
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
|
@coderabbitai review |
✅ Actions performedReview triggered.
|
kirkrodrigues
left a comment
There was a problem hiding this comment.
Technically, we should also update our pyproject.toml files to support Python 3.10+ rather than Python 3.8. Can you make the change?
Something like this:
-requires-python = ">= 3.8"
+requires-python = ">=3.8"
-python = "^3.8 || ^3.10"
+python = ">=3.10"For the PR title, how about:
build(clp-package): Increase minimum Python version from 3.8 to 3.10 as Python 3.8 has reached end-of-life.
|
Can we stay on Python 3.9 since Debian 11 uses 3.9.2 which only reaches EOL on Aug 2026. Similarily, RHEL 8, arch linux and other flavors still uses Python 3.9. |
Sure. @quinntaylormitchell, can you do that? |
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro
📒 Files selected for processing (7)
components/clp-package-utils/pyproject.toml(2 hunks)components/clp-py-utils/pyproject.toml(2 hunks)components/job-orchestration/pyproject.toml(2 hunks)docs/src/dev-guide/building-package.md(1 hunks)docs/src/dev-guide/contributing-linting.md(1 hunks)docs/src/user-guide/guides-multi-node.md(1 hunks)docs/src/user-guide/quick-start/index.md(1 hunks)
🧰 Additional context used
🧠 Learnings (5)
docs/src/dev-guide/contributing-linting.md (1)
Learnt from: quinntaylormitchell
PR: y-scope/clp#968
File: docs/src/user-guide/quick-start/overview.md:53-54
Timestamp: 2025-06-18T20:48:48.990Z
Learning: CLP is designed to run on Linux systems where Python is typically pre-installed, so Python installation links are generally not needed in CLP documentation.
docs/src/user-guide/guides-multi-node.md (1)
Learnt from: quinntaylormitchell
PR: y-scope/clp#968
File: docs/src/user-guide/quick-start/overview.md:53-54
Timestamp: 2025-06-18T20:48:48.990Z
Learning: CLP is designed to run on Linux systems where Python is typically pre-installed, so Python installation links are generally not needed in CLP documentation.
components/clp-package-utils/pyproject.toml (2)
Learnt from: Bill-hbrhbr
PR: y-scope/clp#0
File: :0-0
Timestamp: 2025-07-03T13:33:27.460Z
Learning: In the CLP codebase, `from __future__ import annotations` imports are used to enable Python pipe notation for union types (e.g., `int | str`) in Python versions before 3.10, and should not be considered unused imports.
Learnt from: Bill-hbrhbr
PR: y-scope/clp#0
File: :0-0
Timestamp: 2025-07-03T13:33:27.460Z
Learning: In the CLP codebase, `from __future__ import annotations` imports are used to enable Python pipe notation for union types (e.g., `int | str`) in Python versions before 3.10, and should not be considered unused imports.
docs/src/user-guide/quick-start/index.md (3)
Learnt from: quinntaylormitchell
PR: y-scope/clp#968
File: docs/src/user-guide/quick-start/overview.md:53-54
Timestamp: 2025-06-18T20:48:48.990Z
Learning: CLP is designed to run on Linux systems where Python is typically pre-installed, so Python installation links are generally not needed in CLP documentation.
Learnt from: kirkrodrigues
PR: y-scope/clp#881
File: components/core/tools/scripts/lib_install/ubuntu-jammy/install-prebuilt-packages.sh:35-41
Timestamp: 2025-05-06T09:48:55.408Z
Learning: For installation scripts in the CLP project, prefer explicit error handling over automatic dependency resolution (like `apt-get install -f`) when installing packages to give users more control over their system.
Learnt from: jackluo923
PR: y-scope/clp#1054
File: components/core/tools/scripts/lib_install/musllinux_1_2/install-prebuilt-packages.sh:6-15
Timestamp: 2025-07-01T14:52:15.217Z
Learning: For installation scripts in the CLP project, maintain consistency in command patterns across different platforms (e.g., using separate update and install commands like `apk update && apk add`, `apt update && apt install`, `yum update && yum install`) rather than platform-specific optimizations, to ensure uniform script structure and readability.
components/clp-py-utils/pyproject.toml (2)
Learnt from: Bill-hbrhbr
PR: y-scope/clp#0
File: :0-0
Timestamp: 2025-07-03T13:33:27.460Z
Learning: In the CLP codebase, `from __future__ import annotations` imports are used to enable Python pipe notation for union types (e.g., `int | str`) in Python versions before 3.10, and should not be considered unused imports.
Learnt from: Bill-hbrhbr
PR: y-scope/clp#0
File: :0-0
Timestamp: 2025-07-03T13:33:27.460Z
Learning: In the CLP codebase, `from __future__ import annotations` imports are used to enable Python pipe notation for union types (e.g., `int | str`) in Python versions before 3.10, and should not be considered unused imports.
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
- GitHub Check: lint-check (macos-latest)
- GitHub Check: lint-check (ubuntu-latest)
- GitHub Check: build (macos-latest)
🔇 Additional comments (6)
docs/src/dev-guide/building-package.md (1)
13-13: Python version bump looks correctThe requirement now matches the broader project consensus. No further action needed in this file.
docs/src/user-guide/guides-multi-node.md (1)
10-10: Consistent with new minimum version – LGTMThe doc now correctly reflects the 3.9 baseline.
components/clp-py-utils/pyproject.toml (1)
2-3: No further Python 3.8 references to update
A search forProgramming Language :: Python :: 3.8, CI/workflowpython-version: 3.8, andFROM python:3.8in Dockerfiles returned no matches. All remaining “3.8” occurrences live in lockfiles or npm package metadata and don’t require manual edits.components/clp-package-utils/pyproject.toml (1)
2-3: Same follow-up as other pyproject filesEnsure trove classifiers & CI remove 3.8 and add 3.9 where applicable.
Also applies to: 12-13
components/job-orchestration/pyproject.toml (1)
2-3: Clean-up complete: no Python 3.8 references remainVerified that after updating
requires-python = ">= 3.9"there are no lingering 3.8 mentions in:
- Packaging classifiers (
pyproject.toml)- Dockerfiles (
FROM python:3.8)- docker-compose definitions
- GitHub Actions workflows (both
python-version: 3.8and genericpython:3.8)All checks passed—no further action needed.
docs/src/user-guide/quick-start/index.md (1)
43-45: Update looks good and aligns with project-wide change.No further action needed.
There was a problem hiding this comment.
Actionable comments posted: 1
♻️ Duplicate comments (1)
docs/src/dev-guide/contributing-linting.md (1)
16-17: Add a concrete package-name example for clarity.The parenthetical helps, but novices still search for an exact package string. Consider spelling it out (e.g.,
python3.9-venvon Debian 11,python3.10-venvon Ubuntu 22.04) so that copy-paste installs just work.-* python3-venv (for the version of Python installed) +* python3-venv (match your Python interpreter, e.g., `python3.9-venv` on Debian 11 or `python3.10-venv` on Ubuntu 22.04)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro
📒 Files selected for processing (2)
docs/src/dev-guide/building-package.md(1 hunks)docs/src/dev-guide/contributing-linting.md(1 hunks)
🧰 Additional context used
🧠 Learnings (2)
docs/src/dev-guide/contributing-linting.md (1)
Learnt from: quinntaylormitchell
PR: y-scope/clp#968
File: docs/src/user-guide/quick-start/overview.md:53-54
Timestamp: 2025-06-18T20:48:48.990Z
Learning: CLP is designed to run on Linux systems where Python is typically pre-installed, so Python installation links are generally not needed in CLP documentation.
docs/src/dev-guide/building-package.md (1)
Learnt from: quinntaylormitchell
PR: y-scope/clp#968
File: docs/src/user-guide/quick-start/overview.md:53-54
Timestamp: 2025-06-18T20:48:48.990Z
Learning: CLP is designed to run on Linux systems where Python is typically pre-installed, so Python installation links are generally not needed in CLP documentation.
Co-authored-by: kirkrodrigues <2454684+kirkrodrigues@users.noreply.github.com>
Co-authored-by: kirkrodrigues <2454684+kirkrodrigues@users.noreply.github.com>
Co-authored-by: kirkrodrigues <2454684+kirkrodrigues@users.noreply.github.com>
There was a problem hiding this comment.
Actionable comments posted: 1
♻️ Duplicate comments (4)
components/clp-package-utils/pyproject.toml (2)
2-2: Same comment as earlier: version floor bumped to 3.9 – looks goodNo issues; ensure CI / docs are consistent.
12-12: Redundant python specIdentical observation: may be removed if desired.
components/job-orchestration/pyproject.toml (2)
2-2: 3.9 minimum acknowledgedChange is correct; parity with the other sub-projects maintained.
12-12: Optional cleanupSame redundancy note as above.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro
📒 Files selected for processing (3)
components/clp-package-utils/pyproject.toml(2 hunks)components/clp-py-utils/pyproject.toml(2 hunks)components/job-orchestration/pyproject.toml(2 hunks)
🧰 Additional context used
🧠 Learnings (2)
components/clp-py-utils/pyproject.toml (2)
Learnt from: Bill-hbrhbr
PR: y-scope/clp#0
File: :0-0
Timestamp: 2025-07-03T13:33:27.460Z
Learning: In the CLP codebase, `from __future__ import annotations` imports are used to enable Python pipe notation for union types (e.g., `int | str`) in Python versions before 3.10, and should not be considered unused imports.
Learnt from: Bill-hbrhbr
PR: y-scope/clp#0
File: :0-0
Timestamp: 2025-07-03T13:33:27.460Z
Learning: In the CLP codebase, `from __future__ import annotations` imports are used to enable Python pipe notation for union types (e.g., `int | str`) in Python versions before 3.10, and should not be considered unused imports.
components/clp-package-utils/pyproject.toml (2)
Learnt from: Bill-hbrhbr
PR: y-scope/clp#0
File: :0-0
Timestamp: 2025-07-03T13:33:27.460Z
Learning: In the CLP codebase, `from __future__ import annotations` imports are used to enable Python pipe notation for union types (e.g., `int | str`) in Python versions before 3.10, and should not be considered unused imports.
Learnt from: Bill-hbrhbr
PR: y-scope/clp#0
File: :0-0
Timestamp: 2025-07-03T13:33:27.460Z
Learning: In the CLP codebase, `from __future__ import annotations` imports are used to enable Python pipe notation for union types (e.g., `int | str`) in Python versions before 3.10, and should not be considered unused imports.
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
- GitHub Check: lint-check (ubuntu-latest)
- GitHub Check: build (ubuntu-latest)
🔇 Additional comments (1)
components/clp-py-utils/pyproject.toml (1)
2-2: Python 3.9 floor confirmed across repo & CI
All searches ofpyproject.toml, Dockerfiles, and GitHub Actions workflows show no remaining3.8pins. Raising the minimum to>=3.9is safe.
|
|
||
| [tool.poetry.dependencies] | ||
| python = "^3.8 || ^3.10" | ||
| python = ">= 3.9" |
There was a problem hiding this comment.
🧹 Nitpick (assertive)
Minor duplication – consider dropping the dependency-level spec
[project].requires-python already enforces >=3.9; keeping a second identical
constraint under [tool.poetry.dependencies] is harmless but redundant.
Feel free to leave it, or delete for brevity.
🤖 Prompt for AI Agents
In components/clp-py-utils/pyproject.toml at line 12, there is a redundant
Python version constraint under [tool.poetry.dependencies] since
[project].requires-python already enforces ">=3.9". To fix this, remove the
python = ">= 3.9" line from the dependencies section to avoid duplication and
keep the configuration concise.
…s Python 3.8 has reached end-of-life. (y-scope#1076) Co-authored-by: kirkrodrigues <2454684+kirkrodrigues@users.noreply.github.com>
Description
Currently, the CLP docs state that the minimum version of Python needed to run CLP is 3.8. But Debian 11 uses 3.9.2, and RHEL 8, Arch Linux and other flavors still use Python 3.9. In addition, Python 3.8 reached its end of life in October 2024. Therefore, all
pyproject.tomlfiles have been updated to require at least 3.9, and all references in CLP docs to Python 3.8 have been changed to Python 3.9.Checklist
breaking change.
Validation performed
Built and served the docs to test
.mdfiles; built and ran package to test.tomlfiles.Summary by CodeRabbit
Summary by CodeRabbit
python3-venvdependency must match the installed Python version. No other documentation changes were made.