fix(new-webui): Ensure SUM results fallback to 0 to prevent null values in space savings query (fixes #1012). by junhaoliao · Pull Request #1016 · y-scope/clp

junhaoliao · 2025-06-15T22:09:20Z

Description

In the space savings SQL query, ensure:

the values fallback to 0 SUM() gives null
the values are always UNSIGNED instead of string "0" for example.

Checklist

The PR satisfies the contribution guidelines.
This is a breaking change and that has been indicated in the PR title, OR this isn't a
breaking change.
Necessary docs have been updated, OR no docs need to be updated.

Validation performed

Start CLP package without compressing any files.
cd components/log-viewer-client/client; npm run antd
Accessed http://localhost:3000 in the browser and observed the app did not crash. Instead the uncompressed and compressed sizes were displayed as 0 as expected.

Summary by CodeRabbit

Bug Fixes
- Improved display of space savings totals to always show zero instead of blank when no data is available. Totals are now consistently shown as non-negative numbers.

…es in space savings query (fixes y-scope#1012).

coderabbitai · 2025-06-15T22:09:25Z

Walkthrough

The SQL query within the getSpaceSavingsSql function was updated to use COALESCE(..., 0) around SUM aggregations and to cast the results as UNSIGNED. This ensures that the returned sums default to zero instead of null and are explicitly typed as unsigned integers.

Changes

File	Change Summary
components/log-viewer-webui/client/src/pages/IngestPage/SpaceSavings/sql.ts	Modified SQL query to wrap `SUM` with `COALESCE(..., 0)` and cast results as `UNSIGNED`.

Sequence Diagram(s)

sequenceDiagram
    participant Client
    participant SQLFunction
    participant Database

    Client->>SQLFunction: Call getSpaceSavingsSql()
    SQLFunction->>Database: Execute modified SQL query (with COALESCE and UNSIGNED)
    Database-->>SQLFunction: Return non-null, unsigned sums
    SQLFunction-->>Client: Return processed results

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 1c9f373 and 097b7ee.

📒 Files selected for processing (1)

components/log-viewer-webui/client/src/pages/IngestPage/SpaceSavings/sql.ts (1 hunks)

🧰 Additional context used

📓 Path-based instructions (1)

`**/*.{cpp,hpp,java,js,jsx,tpp,ts,tsx}`: - Prefer `false == ` rather than `!`.

**/*.{cpp,hpp,java,js,jsx,tpp,ts,tsx}: - Prefer false == <expression> rather than !<expression>.

components/log-viewer-webui/client/src/pages/IngestPage/SpaceSavings/sql.ts

🧬 Code Graph Analysis (1)

components/log-viewer-webui/client/src/pages/IngestPage/SpaceSavings/sql.ts (1)

components/log-viewer-webui/client/src/pages/IngestPage/sqlConfig.ts (1)

CLP_ARCHIVES_TABLE_COLUMN_NAMES (59-59)

⏰ Context from checks skipped due to timeout of 90000ms (2)

GitHub Check: lint-check (ubuntu-latest)
GitHub Check: lint-check (macos-latest)

🔇 Additional comments (2)

components/log-viewer-webui/client/src/pages/IngestPage/SpaceSavings/sql.ts (2)

14-25: COALESCE + CAST guard correctly eliminates NULLs—solid improvement ✅
Wrapping the SUM() calls with COALESCE(..., 0) and casting the result as UNSIGNED ensures downstream consumers never see null and always get a numeric 0-default. Implementation looks clean and idiomatic for MySQL.

29-32: Verify driver handling of UNSIGNED BIGINT to avoid silent string coercion
Most Node/MySQL drivers (e.g., mysql2) return BIGINT/UNSIGNED BIGINT columns as JavaScript strings when the value exceeds Number.MAX_SAFE_INTEGER (≈9 quadrillion). If your archive sizes could ever cross that threshold, the current interface typing number will be wrong and may cause subtle bugs.

Please confirm the maximum expected value or enable driver options like supportBigNumbers: true, bigNumberStrings: false (if available) and adjust the SpaceSavingsItem types to string | number accordingly.

✨ Finishing Touches

📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Explain this complex logic.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai explain this code block.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and explain its main purpose.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

…es in space savings query (fixes y-scope#1012). (y-scope#1016)

fix(new-webui): Ensure SUM results fallback to 0 to prevent null valu…

097b7ee

…es in space savings query (fixes y-scope#1012).

junhaoliao requested a review from a team as a code owner June 15, 2025 22:09

junhaoliao requested a review from hoophalab June 15, 2025 22:11

hoophalab approved these changes Jun 16, 2025

View reviewed changes

junhaoliao merged commit 948d6a6 into y-scope:main Jun 16, 2025
9 checks passed

junhaoliao deleted the fix-space-savings-sql branch June 16, 2025 16:37

junhaoliao added a commit to junhaoliao/clp that referenced this pull request May 17, 2026

fix(new-webui): Ensure SUM results fallback to 0 to prevent null valu…

3cfb0a0

…es in space savings query (fixes y-scope#1012). (y-scope#1016)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(new-webui): Ensure SUM results fallback to 0 to prevent null values in space savings query (fixes #1012).#1016

fix(new-webui): Ensure SUM results fallback to 0 to prevent null values in space savings query (fixes #1012).#1016
junhaoliao merged 1 commit into
y-scope:mainfrom
junhaoliao:fix-space-savings-sql

junhaoliao commented Jun 15, 2025 •

edited by coderabbitai Bot

Loading

Uh oh!

coderabbitai Bot commented Jun 15, 2025 •

edited

Loading

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

junhaoliao commented Jun 15, 2025 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Checklist

Validation performed

Summary by CodeRabbit

Uh oh!

coderabbitai Bot commented Jun 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Sequence Diagram(s)

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

junhaoliao commented Jun 15, 2025 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented Jun 15, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)