fix(new-webui): Support top-level await by updating browser compatibility target in Vite config.#1003
Merged
Merged
Conversation
junhaoliao
approved these changes
Jun 12, 2025
| export default defineConfig({ | ||
| base: "./", | ||
| build: { | ||
| target: "esnext", |
Member
There was a problem hiding this comment.
https://esbuild.github.io/api/#target
esnextwhich means that by default, esbuild will assume all of the latest JavaScript and CSS features are supported.
seems that's exactly what we want since we use / will use many latest features
Contributor
Author
|
npm looks to be down, so ci failing |
junhaoliao
pushed a commit
to junhaoliao/clp
that referenced
this pull request
May 17, 2026
…lity target in Vite config. (y-scope#1003) Co-authored-by: Marco <david.marcovitch@yscope.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
#995 introduced a top-level await to support settings loading.
However, the vite config was not configured for this leading to an error during build.
This PR changed the vite config to support top-level await on modern browsers.
Checklist
breaking change.
Validation performed
App now builds.