Skip to content

Bugfix for handling keypress for available widgets#72

Closed
knishiura-lab wants to merge 1 commit into
xwp:masterfrom
knishiura-lab:fix-wrong-event-name-keypress-keydown
Closed

Bugfix for handling keypress for available widgets#72
knishiura-lab wants to merge 1 commit into
xwp:masterfrom
knishiura-lab:fix-wrong-event-name-keypress-keydown

Conversation

@knishiura-lab

@knishiura-lab knishiura-lab commented Jan 12, 2014

Copy link
Copy Markdown

It intended that user can walk through available widgets (middle column in screenshot) by pressing up and down key. Thus, when user hit those keys, selection shoudn't be submit. There was bug in this condition check, and tshis PR fix it.

Tested on Firefox on Ubuntu. On Chrome, both new and old code works for whatever reason.

available-widget

westonruter added a commit that referenced this pull request Jan 13, 2014
@westonruter
Merge branch 'fix-wrong-event-name-keypress-keydown' of https://githu…
2341062 
…b.com/knishiura-lab/wp-widget-customizer into develop

Closes #72
@westonruter

westonruter commented Jan 13, 2014

Copy link
Copy Markdown
Contributor

@knishiura-lab Good catch! I merged into the develop branch and this will be included in the next release.

What's your WordPress.org profile/username?

@knishiura-lab

knishiura-lab commented Jan 13, 2014

Copy link
Copy Markdown
Author

My username is daisy1754
Thanks!

@westonruter

westonruter commented Jan 13, 2014

Copy link
Copy Markdown
Contributor

@knishiura-lab I can't seem to find a profile at http://profiles.wordpress.org/daisy1754/

@knishiura-lab

knishiura-lab commented Jan 15, 2014

Copy link
Copy Markdown
Author

@westonruter
Hmm, I misunderstood what is wordpress account.
I have gravatar account and it's my profile (http://en.gravatar.com/daisy1754 ). I may have made wordpress account as well when taking gravatar account, but not sure. I'm just trying wordpress locally and don't have my own blog hosted by wordpress. Hope it answers your question :)

@westonruter

westonruter commented Jan 15, 2014

Copy link
Copy Markdown
Contributor

@knishiura-lab ok, you want me to link to your Gravatar profile in the changelog?

@knishiura-lab

knishiura-lab commented Jan 15, 2014

Copy link
Copy Markdown
Author

@westonruter
Wow, that would be cool!
Is it possible to put my github url https://github.com/knishiura-lab instead?

@westonruter

westonruter commented Jan 15, 2014

Copy link
Copy Markdown
Contributor

Happily! Thanks again for your contribution. 🙇

@knishiura-lab

knishiura-lab commented Jan 15, 2014

Copy link
Copy Markdown
Author

cool, thanks 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@knishiura-lab @westonruter @daisy1754