initial sortables implementation#14
Conversation
|
Some of the @todo items I have questions about: Also, Need to test with multiple sidebars, as I'm sure the jQuery selectors are not specific / name-spaced enough. |
There was a problem hiding this comment.
@bobbravo2 can you explain how plugins_url is being used here? I don't understand the duplicated self::PLUGIN_DIR. Also, here's another symlink-friendly method for obtaining the plugin URL:
/**
* Not using plugin_dir_url because it is not symlink-friendly
*/
function get_plugin_path_url( $path = null ) {
$plugin_dirname = basename( dirname( __FILE__ ) );
$base_dir = trailingslashit( plugin_dir_url( '' ) ) . $plugin_dirname;
if ( $path ) {
return trailingslashit( $base_dir ) . ltrim( $path, '/' );
} else {
return $base_dir;
}
}Perhaps that could just be added to the Widget_Customizer class as a static method, and then we could just use self::get_plugin_path_url( 'widget-customizer-preview.js' )
There was a problem hiding this comment.
I'm fine with adding the static method. To be honest - I just added a wp() API function to get the proper path to get it up & running.
|
What's next team? I'm new to working on a team 👍 |
|
Ok - my initial reactions on adding a new class that extends WP_Customize_Control, is that it feels a bit overkill. Also, since we're not using the control's renderer (render_content() callback) to display any user facing interface. Although - I haven't looked too deeply into the API in terms of adding data to a control, and having the control handle the customize(d) view. That may outweigh my perceived drawbacks. What about storing a temporary option in the wp_options table - and then filtering the display_sidebar order when the customizer is active? That approach would also allow us to add "sidebar" locking to prevent 2 users from customizing the sidebar at the same time. |
|
@bobbravo2 sorry for the delay. I've just pulled in your commits to the issue (#1) and created a branch ( |
No description provided.