Update CupertinoIcons script and regenerate the font #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LongCatIsLooong
commented
Apr 14, 2024
| "trash_fill": [0xf4c5], | ||
| "pencil": [0xf37e, 0xf2bf], | ||
| "square_pencil": [0xf417], | ||
| "square_pencil_fill": [0xf418], |
Author
There was a problem hiding this comment.
This is changed from 0xf417 to 0xf418
11 tasks
auto-submit bot
pushed a commit
to flutter/packages
that referenced
this pull request
Apr 16, 2024
…rsion to 1.08 (#6520) See this PR for the font change: xster/framework7-icons#2
|
@LongCatIsLooong @xster I didn't realize we were using scripts from https://github.com/xster. Can we move this into https://github.com/flutter/packages? |
Owner
|
oh man, I'm a bit embarrassed that it's still here. It's definitely outlived it's shelf life. I did it here because I thought these icons would live for about 2 years like the previous design. If we think these stuff will live for a while, it'd be best to move them to somewhere more suitable long term. |
This was referenced May 9, 2024
TecHaxter
pushed a commit
to TecHaxter/flutter_packages
that referenced
this pull request
May 22, 2024
…rsion to 1.08 (flutter#6520) See this PR for the font change: xster/framework7-icons#2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch:
Removes ligature tablesRemoves the glyph names from the post tableLooks like the cheatsheet and dartdoc are still using the ligatures tech. So the ligature tables are kept.
Fix overlapping outlines
Multiple SVGs with the same file name were mapped to the same codepoint, so the SVGs were imported into the same glyph.
square_pencil_fill(create_solid) were mapped to the same glyph assquare_pencil(create) ([cupertino_icons] Icons for create and create_solid from CupertinoIcons are the same (and buggy) flutter/flutter#106065). The former is mapped to0xf418in the patch.carandcar_fillwere using different svgs, despite the documentation claim them being the same icon ([Cupertino icons]Glyphs for car and car_fill from CupertinoIcons are broken flutter/flutter#98029). The patch treatscar_fillas an alias ofcarto match the documentation.A few asserts were added in the script to guard against importing multiple outlines to the same glyph.
Regenerate font
This seems to fix the vertical alignment. This should fix flutter/flutter#143069. Comparison (left: old, right: new):