[Pfc] Fix usage of saveptr in strtok_r used by PathTokenizer #2455
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implement the equivalent of strtok_r with reproducible beahavior across architectures. Previous implementation relied on undocumented behavior of the Linux implementation and was causing SEGVs on mac-OS. Extend initial implementation of XrdPfcTests by Brian Bockelman to cover more use-cases.
amadio
approved these changes
Mar 17, 2025
Member
amadio
left a comment
There was a problem hiding this comment.
Looks good, I trust that the added test ensures that things work of course!
abh3
reviewed
Mar 18, 2025
Member
abh3
left a comment
There was a problem hiding this comment.
That's a lot of changes to just get rid of strtok_r() so I must not be seeing the whole picture here. Anyway, I didn't see anything glaring but given the changes I would certainly fully test this out.
Contributor
Author
Contributor
Author
|
I'll run this (master) on a production cache at UCSD, building now. |
Member
|
Please try to play with number of streams per channel. I hope that the performance fix in the client can be seen in XCache (see my CHEP24 presentation for details). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement the equivalent of strtok_r with reproducible beahavior across architectures. Previous implementation relied on undocumented behavior of the Linux implementation and was causing SEGVs on mac-OS.
This addresses #2450.
This PR also includes a prototype implementation of XrdPfcTests by @bbockelm and extends it to cover more use-cases, thus superseding the now closed #2451.