-
Notifications
You must be signed in to change notification settings - Fork 166
[XrdPfc] Add simple unit test example for XrdPfc tokenizer #2451
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
|
||
| TEST(XrdPfcTests, PathTokenizer) | ||
| { | ||
| PathTokenizer("/pelican/hello_world.txt", 0, true); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this would be a lot simpler if you used loops (see XrdClURL test).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes - I assume that Alja and Matevz will expand it into a larger test by pushing to the branch and not using as-is. Just wanted to help show the crash.
|
Sorry for being stoopid, but how is one supposed to run the tests? :) I tried, in my build: and then, from the source directory |
|
@osschar You are likely missing dependencies to run the tests (see summary at configuration step). If you are on an RPM-based distro, try |
|
Thank you @amadio, this helped! :) |
|
A cherry-pick sounds good! As @amadio mentions, you'll probably want to flesh out the test to check the actual functionality of the class beyond "it doesn't crash". (Closing for now since it'll be in the other branch) |
|
Included in PR #2455. |
Done for @osschar and @alja to show crash reported in #2450.
This segfaults when run with address sanitizer. I assume Matevz can push fixes to actually make check for correct values.