Skip to content

fix(predictor): Fix predict_threadable to properly handle symlinks, especially on NixOS#6115

Merged
anki-code merged 8 commits into
xonsh:mainfrom
anki-code:fix_symlink_predictor
Mar 5, 2026
Merged

fix(predictor): Fix predict_threadable to properly handle symlinks, especially on NixOS#6115
anki-code merged 8 commits into
xonsh:mainfrom
anki-code:fix_symlink_predictor

Conversation

@anki-code

@anki-code anki-code commented Mar 5, 2026

Copy link
Copy Markdown
Member

@anki-code anki-code requested review from gforsyth and jnoortheen March 5, 2026 07:17
@anki-code anki-code changed the title fix(predictor): Fixed predict_threadable to work properly the symlinks especially in NixOS fix(predictor): Fix predict_threadable to properly handle symlinks, especially on NixOS Mar 5, 2026
@anki-code

Copy link
Copy Markdown
Member Author

I'm going to do self-release because of tests are here and we want to have this in weekly fix release.

@anki-code anki-code merged commit bc01b04 into xonsh:main Mar 5, 2026
15 checks passed
anki-code pushed a commit that referenced this pull request Mar 5, 2026
🤖 I have created a release *beep* *boop*
---


## [0.22.5](0.22.4...0.22.5)
(2026-03-05)


### Features

* Added useful command decorators: `[@lines](https://github.com/lines)`,
`[@JSON](https://github.com/json)`,
`[@jsonl](https://github.com/jsonl)`, `[@yaml](https://github.com/yaml)`
([#6114](#6114))
([0f7124e](0f7124e))


### Bug Fixes

* **completion:** Fix os.path.commonprefix deprecation warning in
python3.15 ([#6102](#6102))
([2b5b2bb](2b5b2bb))
* Increase `@$()` stability and now it is also working in case of
`$THREAD_SUBPROCS=False`
([#6112](#6112))
([a3ac036](a3ac036))
* **predictor:** Fix predict_threadable to properly handle symlinks,
especially on NixOS
([#6115](#6115))
([bc01b04](bc01b04))
* **prompt:** Keep original key_bindings in prompt-toolkit shell to easy
add new key bindings during session
([#6093](#6093))
([e9b0aea](e9b0aea))
* replace 12 bare except clauses with except Exception
([#6110](#6110))
([54b311c](54b311c))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: xonsh-credentials-bot[bot] <97968350+xonsh-credentials-bot[bot]@users.noreply.github.com>
anki-code added a commit that referenced this pull request Mar 5, 2026
In #5440 we had coreutils support. But in #6115 we introduced additional
logic for symlink resolving. This breaks `cat` and `yes` predictions (we
have True instead of False). So this PR has additional fixes for logic
and tests.


## For community
⬇️ **Please click the 👍 reaction instead of leaving a `+1` or 👍
comment**

---------

Co-authored-by: Andy Kipp <123@321.123>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

On NixOS, where cmd is a script with a non-/usr/bin/env shebang path, @$(cmd) does not capture output, but de-sugaring it does

1 participant