Merged
Conversation
741e931 to
54778f7
Compare
As advised in [1], provide a way to set the path for the xmessage and ghc binaries via XMONAD_XMESSAGE and XMONAD_GHC environment variables. [1]: NixOS/nixpkgs@36d5761
Member
|
Thank you! (I just added the PR description to the commit) |
|
I've opened a PR to reflect this change on the NixOS side: NixOS/nixpkgs#184784. After this, xmonad from master should work with the module shipped with NixOS directly. |
13 tasks
sternenseemann
added a commit
to sternenseemann/nixpkgs
that referenced
this pull request
Sep 14, 2022
We had a long standing downstream patch for XMonad allowing us to override the ghc and xmessage binaries used. That has been upstreamed and released in 0.17.1 and we can drop it! * patch upstreamed in xmonad/xmonad#409 * downstream patch adjusted in NixOS#184784
sternenseemann
added a commit
to NixOS/nixpkgs
that referenced
this pull request
Sep 14, 2022
We had a long standing downstream patch for XMonad allowing us to override the ghc and xmessage binaries used. That has been upstreamed and released in 0.17.1 and we can drop it! * patch upstreamed in xmonad/xmonad#409 * downstream patch adjusted in #184784
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
As advised in NixOS/nixpkgs@36d5761 this PR provides a way to set the path for
xmessageandghcbinaries via environment variablesXMONAD_XMESSAGEandXMONAD_GHC.Checklist
I've read CONTRIBUTING.md
I've confirmed these changes don't belong in xmonad-contrib instead
I've considered how to best test these changes (property, unit,
manually, ...) and concluded: XXX
I updated the
CHANGES.mdfile