Skip to content

Fixing typo in the signature of withNamespaceContext method.#62

Merged
bodewig merged 1 commit into
xmlunit:masterfrom
mariusneo:prefix2Uri-fix
Mar 17, 2016
Merged

Fixing typo in the signature of withNamespaceContext method.#62
bodewig merged 1 commit into
xmlunit:masterfrom
mariusneo:prefix2Uri-fix

Conversation

@mariusneo

Copy link
Copy Markdown
Contributor

Currently within the signature of DiffBuilder and CompareMatcher exists a typo :

public DiffBuilder withNamespaceContext(Map<String, String> uri2Prefix)

which may very likely be misleading for new users of the library.
The mapping is between prefixes and URIs and not the other way arround (as expected by Convet.toNamespaceContext(Map<String,String) prefix2Uri) method

Issue : #61

bodewig added a commit that referenced this pull request Mar 17, 2016
Fixing typo in the signature of withNamespaceContext method.
@bodewig bodewig merged commit 3750053 into xmlunit:master Mar 17, 2016
@bodewig

bodewig commented Mar 17, 2016

Copy link
Copy Markdown
Member

Good catch, thanks!

bodewig added a commit that referenced this pull request Mar 17, 2016
@bodewig bodewig added this to the 2.1.0 milestone Mar 17, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants