Skip to content

add withNamespaceContext(Map) to CompareMatcher#54

Merged
bodewig merged 1 commit into
xmlunit:masterfrom
cboehme:add-CompareMatcher-withNamespaceContext
Mar 6, 2016
Merged

add withNamespaceContext(Map) to CompareMatcher#54
bodewig merged 1 commit into
xmlunit:masterfrom
cboehme:add-CompareMatcher-withNamespaceContext

Conversation

@cboehme

@cboehme cboehme commented Mar 6, 2016

Copy link
Copy Markdown
Contributor

The withNamespaceContext(Map) method was missing on CompareMatcher.

bodewig added a commit that referenced this pull request Mar 6, 2016
…ontext

add withNamespaceContext(Map) to CompareMatcher
@bodewig bodewig merged commit 498e032 into xmlunit:master Mar 6, 2016
@bodewig

bodewig commented Mar 6, 2016

Copy link
Copy Markdown
Member

Thanks, good catch. Don't know why those two classes have run out of sync.

@bodewig

bodewig commented Mar 6, 2016

Copy link
Copy Markdown
Member

Ported the fix to XMLUnit.NET, pushed a snapshot to our Maven repo and updated the apidocs - do you need a new proper release immediately?

@cboehme

cboehme commented Mar 6, 2016

Copy link
Copy Markdown
Contributor Author

There's no rush for a new release. I came across the missing method when experimented with namespace handling in xmlunit, but in the end I didn't need the method in the my test cases.

@bodewig

bodewig commented Mar 7, 2016

Copy link
Copy Markdown
Member

Thank you, so I'll give us a bit more time to accumulate more fixes.

@bodewig bodewig added this to the 2.0.1 milestone Mar 13, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants