squid:S1854 - Dead stores should be removed#52
Merged
bodewig merged 1 commit intoMar 1, 2016
Merged
Conversation
Contributor
|
I agree that dead stores are a smaller bad habit. I also would like to thanks @georgekankava for the effort. I find it quite usefull that users review the code. Considering that only such minor issues occur with sonarqube is also a good sign, that the overall quality is really good. This really is of cosmetic nature, but I would recommend to accept the request to encourage people to commit. Kind regards, |
bodewig
added a commit
that referenced
this pull request
Mar 1, 2016
…removed-fix-1 squid:S1854 - Dead stores should be removed
Member
|
Thanks a lot @georgekankava , I'll port this to .NET as well. And thank you for your second pair of eyes @phbenisc :-) |
Member
|
I just now realized this PR only affects the legacy module, so there isn't anything that would need porting. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request is focused on resolving occurrences of Sonar rule
squid:S1854 - Dead stores should be removed.
You can find more information about the issue here:
https://dev.eclipse.org/sonar/rules/show/squid:S1854
Please let me know if you have any questions.
George Kankava