Skip to content

Improve io.read and io.readfile#7273

Merged
waruqi merged 5 commits intodevfrom
io
Jan 28, 2026
Merged

Improve io.read and io.readfile#7273
waruqi merged 5 commits intodevfrom
io

Conversation

@waruqi
Copy link
Member

@waruqi waruqi commented Jan 28, 2026 •
edited
Loading

@waruqi waruqi added this to the v3.0.7 milestone Jan 28, 2026
@gemini-code-assist
Copy link
Contributor

gemini-code-assist bot commented Jan 28, 2026

Summary of Changes

Hello @waruqi, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly improves the io.read functionality by enabling robust handling of sequential file streams, such as those commonly found in the /proc filesystem on Linux. It introduces specific optimizations for reading and skipping data in these types of streams, which contributes to overall performance enhancements. Additionally, the changes include better line ending normalization and a more modular structure for file reading operations, ensuring greater reliability and consistency across different file types and operating systems.

Highlights

  • Support for /proc files: Introduced logic to correctly handle reading from sequential file streams, such as those found in the /proc filesystem on Linux, which often do not report a fixed size.
  • I/O Read Speed Optimization: Implemented new xm_io_file_stream_skip_sequential and xm_io_file_stream_skip functions to optimize skipping and reading operations, particularly for sequential streams, aiming to improve overall io.read performance.
  • Line Ending Normalization: Enhanced the xm_io_file_read_all function to automatically normalize Windows-style \r\n line endings to Unix-style \n when reading file content, ensuring consistent output.
  • Refactored Read Functions: The xm_io_file_read_all function has been refactored to use new helper functions like xm_io_file_read_all_to_buffer and xm_io_file_read_all_with_continuation, improving modularity and error handling.
  • New Test Case: Added a new test test_read_proc_cpuinfo to verify the functionality of reading /proc/cpuinfo on Linux, confirming the successful implementation of /proc file support.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

@waruqi waruqi changed the title Improve io.read Improve io.read and io.readfile Jan 28, 2026
gemini-code-assist[bot]
gemini-code-assist bot reviewed Jan 28, 2026
View reviewed changes
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces significant improvements to io.read and io.readfile, primarily by adding support for non-seekable streams like those in /proc and optimizing read performance. The changes are well-thought-out, including refactoring for better code structure and a fix for a subtle bug in xm_io_file_buffer_readline. The addition of a test case for reading /proc/cpuinfo is also a great way to validate the new functionality. I have found one potential issue in the new sequential skip implementation and provided a suggestion for a fix. Overall, this is a valuable contribution.

@waruqi waruqi merged commit 11dd96c into dev Jan 28, 2026
70 checks passed
@waruqi waruqi deleted the io branch January 28, 2026 09:36
@waruqi waruqi mentioned this pull request Jan 28, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

v3.0.7

Development

Successfully merging this pull request may close these issues.

1 participant

@waruqi