enhance shell detection for Linux by checking parent process#7267
enhance shell detection for Linux by checking parent process#7267waruqi merged 11 commits intoxmake-io:devfrom
Conversation
Summary of ChangesHello @luadebug, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances the shell detection capabilities for Linux environments. By introducing a parent process traversal mechanism, the system can more reliably identify the shell from which Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request enhances shell detection on Linux by traversing the parent process tree to identify the shell. This is a good improvement for cases where environment variables are not set.
However, I've found a critical issue in the implementation. The use of os.execv to copy files from /proc will terminate the xmake process. This needs to be replaced with os.run.
I've also included a couple of suggestions to improve maintainability by reducing code duplication. Please take a look at the detailed comments.
…n and error handling
idea similiar to #6927 but for Linux not for Windows.
Would it be convenient to place :lower() & :upper() next to utf8 module instead of overriding existing methods of string.lower string.upper, as we have .reverse() method already inside of utf8 module? or either place reverse.c that overrides reverse for string