Conversation
waruqi
commented
Oct 10, 2025
- Before adding new features and new modules, please go to issues to submit the relevant feature description first.
- Write good commit messages and use the same coding conventions as the rest of the project.
- Please commit code to dev branch and we will merge into master branch in feature
- Ensure your edited codes with four spaces instead of TAB.
- 增加新特性和新模块之前，请先到issues提交相关特性说明，经过讨论评估确认后，再进行相应的代码提交，避免做无用工作。
- 编写友好可读的提交信息，并使用与工程代码相同的代码规范，代码请用4个空格字符代替tab缩进。
- 请提交代码到dev分支，如果通过，我们会在特定时间合并到master分支上。
- 为了规范化提交日志的格式，commit消息，不要用中文，请用英文描述。
Summary of ChangesHello @waruqi, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances Xmake's symbol export capabilities on Windows by extending the application of Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request extends the support for .def files to binaries on Windows, in addition to shared libraries. The changes are generally in the right direction, but there are a couple of places where the toolchain detection is too specific, which could cause issues with common MinGW setups using GCC. I've suggested expanding the compiler checks to be more robust. Additionally, I've noted some duplicated logic for flag generation that could be refactored to improve maintainability.
| elseif target:has_tool("ld", "clangxx") then | ||
| flag = "-Wl,/def:" .. flag | ||
| matched = true | ||
| end |
There was a problem hiding this comment.
The check target:has_tool("ld", "clangxx") is too specific and doesn't cover other GNU-like compilers such as gcc, g++, or clang which are common on MinGW. This could lead to .def files not being processed correctly for those toolchains. It should be expanded to include them to ensure correctness on different MinGW setups.
elseif target:has_tool("ld", "clang", "clangxx", "gcc", "gxx") then
flag = "-Wl,/def:" .. flag
matched = true
end
| elseif target:is_plat("windows") and target:has_tool("ld", "clangxx") then | ||
| exportkind = "def" | ||
| exportfile = path.join(target:autogendir(), "rules", "symbols", "export_list.def") | ||
| target:add("shflags", "-Wl,/def:" .. exportfile, {force = true}) | ||
| target:add("ldflags", "-Wl,/def:" .. exportfile, {force = true}) |
There was a problem hiding this comment.
Similar to the other file, the condition target:has_tool("ld", "clangxx") is too specific. For MinGW, gcc and g++ are common linkers. Without including them, this rule will fall back to generating a version script (.map file), which is incorrect for Windows PE targets. The condition should be expanded to include other GNU-like compilers.
elseif target:is_plat("windows") and target:has_tool("ld", "clang", "clangxx", "gcc", "gxx") then
exportkind = "def"
exportfile = path.join(target:autogendir(), "rules", "symbols", "export_list.def")
target:add("shflags", "-Wl,/def:" .. exportfile, {force = true})
target:add("ldflags", "-Wl,/def:" .. exportfile, {force = true})
| if target:has_tool("ld", "link") then | ||
| flag = "/def:" .. flag | ||
| matched = true | ||
| elseif target:has_tool("ld", "clangxx") then | ||
| flag = "-Wl,/def:" .. flag | ||
| matched = true | ||
| end |
There was a problem hiding this comment.
The logic for generating the linker flag for .def files is duplicated in xmake/rules/utils/symbols/export_list/xmake.lua. To improve maintainability and avoid inconsistencies, consider creating a helper function that encapsulates this logic. This function could take the target and filepath as arguments and return the appropriate flag string based on the detected toolchain (MSVC vs. GNU-like). This would centralize the logic for handling .def files on Windows.
|
implib感觉也可以加上 |
Implib feels like it can also be added |
|