Conversation
Summary of ChangesHello @luadebug, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request refines the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request improves the generation of CMake import files by replacing a hardcoded list of 32-bit architectures with a dynamic check using target:check_sizeof("void*"). This makes the determination of the target pointer size much more robust and correct. I've added one medium-severity comment regarding the potential for this check to be run during the install phase, which could be a performance concern. However, this is a minor design point, and the overall change is a significant improvement in correctness and maintainability.
| TARGETKIND = target:is_headeronly() and "INTERFACE" or (target:is_shared() and "SHARED" or "STATIC"), | ||
| PACKAGE_VERSION = target:get("version") or "1.0.0", | ||
| TARGET_PTRBYTES = target:is_arch("armeabi", "armeabi-v7a", "x86", "mips", "i386", "armv7", "armv7s", "mipsel", "wasm32") and "4" or "8"} | ||
| TARGET_PTRBYTES = target:check_sizeof("void*")} |
There was a problem hiding this comment.
Using target:check_sizeof is a great improvement for correctness over the previous hardcoded list. However, since this is a detection function, it may trigger a compilation during the install phase if its result is not already cached. This can be slow and might be surprising to users. For future improvement, consider if this value can be reliably determined and cached during the configuration phase, so that it can be retrieved here without performing a check.
* gettext: add mirror for xmake-io/xmake#6880 * fixup * fixup * Update xmake.lua
xmake-io/xmake-repo#8277 (comment)
XMake has issues during auto-generation of CMakeConfigs for cross 32 bit builds it keeps claiming that is 64 bit one CMakeConfig.
xmake-io/xmake-repo#8280 (minizip)
xmake-io/xmake-repo#8277 (imgui)