(C++ module support) improve jobgraph support#6373

Merged

waruqi merged 12 commits intoxmake-io:devfrom

Arthapz:improve-jobgraph-support

May 11, 2025

Member

Arthapz commented Apr 27, 2025 •

edited

Loading

disable build.fence and enable full parallelization
support clang two phase compilation and add policy to toggle it build.c++.modules.two_phases
improve module build artifact reutilisation and introduce build.c++.modules.reuse.nocheck to force reutilisation without checking flags
modules from other targets now have includedirs flags from their original target when not reused (should partially fixes clang-scan-deps commandline misses target flags on command line #6028 (comment)) (should be the same behavior as modules from packages)
fix --sdk= when using llvm toolchain on windows with msstl std module

part 5 (and last) of #6336

should fixes #6399 (comment)
fixes #6383
fixes #5765
fixes #3003
fixes #4087
fixes #6407
partially fixes (no support for std module) #5765

Arthapz force-pushed the improve-jobgraph-support branch 5 times, most recently from 2d5b6c7 to e3de38e Compare

April 27, 2025 17:09

waruqi reviewed

View reviewed changes

xmake/rules/c++/modules/support.lua Outdated Show resolved Hide resolved

waruqi reviewed

View reviewed changes

xmake/rules/c++/modules/support.lua Outdated Show resolved Hide resolved

Arthapz force-pushed the improve-jobgraph-support branch 2 times, most recently from a2e3d84 to 77bb2fd Compare

April 29, 2025 14:46

waruqi reviewed

View reviewed changes

xmake/core/tool/toolchain.lua Outdated Show resolved Hide resolved

waruqi reviewed

View reviewed changes

xmake/core/tool/toolchain.lua Outdated Show resolved Hide resolved

waruqi reviewed

View reviewed changes

xmake/rules/c++/modules/msvc/support.lua Show resolved Hide resolved

waruqi reviewed

View reviewed changes

xmake/rules/c++/modules/builder.lua Outdated Show resolved Hide resolved

waruqi reviewed

View reviewed changes

xmake/rules/c++/modules/builder.lua Outdated Show resolved Hide resolved

waruqi reviewed

View reviewed changes

xmake/rules/c++/modules/builder.lua Outdated Show resolved Hide resolved

waruqi reviewed

View reviewed changes

xmake/rules/c++/modules/builder.lua Outdated Show resolved Hide resolved

waruqi reviewed

View reviewed changes

xmake/rules/c++/modules/clang/builder.lua Outdated Show resolved Hide resolved

waruqi reviewed

View reviewed changes

xmake/rules/c++/modules/clang/support.lua Outdated Show resolved Hide resolved

Member

waruqi commented Apr 29, 2025

What are the main improvements made in this patch?

Member Author

Arthapz commented Apr 29, 2025 •

edited

Loading

What are the main improvements made in this patch?

disable build.fence and enable full parallelization
support clang two phase compilation and add policy to toggle it build.c++.modules.two_phases
improve module build artifact reutilisation and introduce build.c++.modules.reuse.nocheck to force reutilisation without checking flags
modules from other targets now have includedirs flags from their original target when not reused (should partially fixes clang-scan-deps commandline misses target flags on command line #6028 (comment)) (should be the same behavior as modules from packages)
fix --sdk= when using llvm toolchain on windows with msstl std module

Arthapz force-pushed the improve-jobgraph-support branch 4 times, most recently from 652e310 to 8d8cdbe Compare

April 30, 2025 14:29

waruqi reviewed

View reviewed changes

xmake/rules/c++/modules/builder.lua Outdated Show resolved Hide resolved

waruqi reviewed

View reviewed changes

xmake/rules/c++/modules/install.lua Outdated Show resolved Hide resolved

waruqi reviewed

View reviewed changes

xmake/rules/c++/modules/support.lua Outdated Show resolved Hide resolved

Arthapz force-pushed the improve-jobgraph-support branch 2 times, most recently from 01864d3 to 31dceaa Compare

May 1, 2025 00:22

waruqi closed this

Arthapz force-pushed the improve-jobgraph-support branch 6 times, most recently from f4a3b05 to 0beb8ac Compare

May 9, 2025 13:49

Arthapz added 9 commits

May 9, 2025 15:56


          (C++ module support) improve jobgraph support

5d6d36e


          (C++ modules support) fix CMake generation

41bb464


          (C++ modules support) add tests

b1578e6


          (cmake) fix fileset support version checking

e2e4242


          (C++ modules support) fix is_dependencies_changed

1a62ccd

fixes xmake-io#6383


          (C++ modules support) fix cmake test


          (C++ modules support) fix non named module with module extension not …

465e4dd

…built


          (C++ modules support) add test for non named module with custom exten…

60b0eb8

…sion


          (C++ modules support) fix module compilation for clang

b24998d

Arthapz force-pushed the improve-jobgraph-support branch from 672ede4 to b24998d Compare

May 9, 2025 13:56


          (C++ modules support) fix hello_mpp test for compiler without <print>…

fdc7b4e

… header

Arthapz force-pushed the improve-jobgraph-support branch from e29641a to fdc7b4e Compare

May 9, 2025 16:27

Arthapz added 2 commits

May 10, 2025 22:07


          (C++ modules support) fix modules not saved in cache if missing depen…

8149a35

…dencies


          (C++ modules support) fix module parsing when file are added

fca3c75

Arthapz force-pushed the improve-jobgraph-support branch from b7dc824 to fca3c75 Compare

May 10, 2025 20:19

Member

waruqi commented May 11, 2025

Does it ready now?

Issues-translate-bot commented May 11, 2025

Bot detected the issue body's language is not English, translate it automatically.

Does it ready now?

Member Author

Arthapz commented May 11, 2025

i think so

Member

waruqi commented May 11, 2025

ok, I will review it in these days.

waruqi added this to the v3.0.0 milestone

Member

waruqi commented May 11, 2025

Thanks! 👍

waruqi merged commit c357c9b into xmake-io:dev

22 checks passed

Issues-translate-bot commented May 11, 2025

Bot detected the issue body's language is not English, translate it automatically.

Thanks! 👍

Arthapz deleted the improve-jobgraph-support branch

September 18, 2025 09:22

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment