XMake 3.0 modules support (jobgraph, deprecation and improvements)#6336
Closed
Arthapz wants to merge 3 commits intoxmake-io:devfrom
Closed
XMake 3.0 modules support (jobgraph, deprecation and improvements)#6336Arthapz wants to merge 3 commits intoxmake-io:devfrom
Arthapz wants to merge 3 commits intoxmake-io:devfrom
Conversation
fe1e897 to
ebc643e
Compare
Member
|
I don't have much time to review such a large patch, nor can I test them in detail. This may introduce a lot of uncertainty and stability. so I suggest splitting it into multiple patches as much as possible. |
ebc643e to
553a93a
Compare
553a93a to
506b205
Compare
This was referenced Apr 20, 2025
Member
Author
|
@waruqi i have reduced it to now it's hard to split it as all the work is dependent, is it okay ? |
Member
ok, but I might need a few days to review it. |
Member
Author
no problem, take your time |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
build.c++.modules.two_phasesbuild.c++.modules.tryreuse, introducebuild.c++.modules.reuseinsteadbuild.c++.modules.tryreuse.discriminate_on_defines, introducebuild.c++.modules.reuse.strictinsteadbuild.c++.gcc/clang/msvc.fallbackscanner, introducebuild.c++.modules.gcc/clang/msvc.fallbackscannerinsteadbuild.c++.gcc.modules.cxx11abi, introducebuild.c++.modules.gcc.cxx11abiinsteadbuild.c++.modules.reuse.nocheckto force reutilisation without checking flags