Skip to content

test template#3

Merged
xiowu0 merged 1 commit into
litemp2from
testTemp
May 7, 2019
Merged

test template#3
xiowu0 merged 1 commit into
litemp2from
testTemp

Conversation

@xiowu0

@xiowu0 xiowu0 commented May 7, 2019

Copy link
Copy Markdown
Owner

Title (one Line SUMMARY)

for cherry-pick, add Cherry-Pick keyword to the title

e.g., Cherry-Pick KAFKA-7288: Fix for SslSelectorTest.testCloseConnectionInClosingState

Commit message body

DESCRIPTION (Required)

What/why/how was this change made?

test pull msg
COMPLETION CRITERIA (Required)

Condition under which this Hot-Fix patch is not needed anymore.

If Cherry-Pick, please specify the first release that we don’t need to cherry-pick this patch

UPSTREAM TICKET (Required if need Upstream)

A companion upstream ticket (KAFKA-xxxx) which tracks the upstream commit status of this patch)

@xiowu0 xiowu0 merged commit 4e8f23f into litemp2 May 7, 2019
xiowu0 pushed a commit that referenced this pull request Dec 3, 2020
…pache#7305)

A partition log in initialized in following steps:

1. Fetch log config from ZK
2. Call LogManager.getOrCreateLog which creates the Log object, then
3. Registers the Log object

Step #3 enables Configuration update thread to deliver configuration
updates to the log. But if any update arrives between step #1 and #3
then that update is missed. It breaks following use case:

1. Create a topic with default configuration, and immediately after that
2. Update the configuration of topic

There is a race condition here and in random cases update made in
second step will get dropped.

This change fixes it by tracking updates arriving between step #1 and #3
Once a Partition is done initializing log, it checks if it has missed any
update. If yes, then the configuration is read from ZK again.

Added unit tests to make sure a dirty configuration is refreshed. Tested
on local cluster to make sure that topic configuration and updates are
handled correctly.

Reviewers: Jason Gustafson <jason@confluent.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant