This repository was archived by the owner on May 1, 2024. It is now read-only.
[Core] Fix layout padding update issue#4166
Merged
StephaneDelcroix merged 1 commit intoxamarin:3.4.0from Oct 26, 2018
Merged
Conversation
70941b0 to
c2249b4
Compare
StephaneDelcroix
approved these changes
Oct 22, 2018
Member
StephaneDelcroix
left a comment
There was a problem hiding this comment.
The gallery page is nice, but adding a UnitTest (in X.F.Core.UnitTests) will ensure that we do not regress this in the future. Do you think you could add one ?
hartez
approved these changes
Oct 22, 2018
c2249b4 to
2991788
Compare
Contributor
Author
|
@StephaneDelcroix Sure, I update UnitTest(StackLayoutUnitTests) |
Member
|
@myroot one last thing. could you rebase this on 3.4.0 ? |
Contributor
Author
|
@StephaneDelcroix Ok, but I can update on friday. and Should I pull request into 3.4.0 branch? |
Contributor
|
@myroot you can rebase the branch by
Once you've done that then
|
- Update PaddingPropertyChanged handler - Add UnitTest for Padding - Update ControlGallery
2991788 to
e017c22
Compare
Contributor
Author
|
@PureWeen Thanks! |
Contributor
|
@myroot Thank you!! I kicked off the UI tests again just to make sure we're all good. After that we'll merge |
StephaneDelcroix
pushed a commit
that referenced
this pull request
Oct 26, 2018
- Update PaddingPropertyChanged handler - Add UnitTest for Padding - Update ControlGallery - fixes #4165
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
This PR update code of
IPaddingElement.OnPaddingPropertyChangedon Layoutfrom
InvalidateMeasureInternal(InvalidationTrigger.MeasureChanged)toInvalidateLayout()Because, When size of layout was not changed by Padding, children element does not re-layouting with
InvalidateMeasureInternal(InvalidationTrigger.MeasureChanged)Issues Resolved
API Changes
None
Platforms Affected
Behavioral/Visual Changes
None
Before/After Screenshots
Before
After
Testing Procedure
PR Checklist