This repository was archived by the owner on May 1, 2024. It is now read-only.
[CSS] allow mapping css prop to multiple BPs#3437
Merged
StephaneDelcroix merged 1 commit intomasterfrom Jul 31, 2018
Merged
Conversation
To allow mapping a single CSS property to multiple controls, we so far relied on extracting the BindableProperties to static helper classes, and implementing an interface for accessors, and eventually change handlers. That extraction works well, and is actually a good pattern, as long as: - the extracted BPs share the same PropertyName, - default value, and - return type, obiously As the CSS `color` property has to map to both `TextColor` and `Color` BPs, the property extraction wasn't possible. This change adds the capability to map a single CSS property to multiples BPS, when extraction isn't possible. Whenever the extraction to an interface is possible, that behavior is strongly encouraged.
samhouts
approved these changes
Jul 30, 2018
Contributor
|
That'll do it, alright. |
PureWeen
pushed a commit
that referenced
this pull request
Aug 28, 2018
To allow mapping a single CSS property to multiple controls, we so far relied on extracting the BindableProperties to static helper classes, and implementing an interface for accessors, and eventually change handlers. That extraction works well, and is actually a good pattern, as long as: - the extracted BPs share the same PropertyName, - default value, and - return type, obiously As the CSS `color` property has to map to both `TextColor` and `Color` BPs, the property extraction wasn't possible. This change adds the capability to map a single CSS property to multiples BPS, when extraction isn't possible. Whenever the extraction to an interface is possible, that behavior is strongly encouraged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
To allow mapping a single CSS property to multiple controls, we so far
relied on extracting the BindableProperties to static helper classes,
and implementing an interface for accessors, and eventually change
handlers.
That extraction works well, and is actually a good pattern, as long as:
As the CSS
colorproperty has to map to bothTextColorandColorBPs, the property extraction wasn't possible.
This change adds the capability to map a single CSS property to
multiples BPS, when extraction isn't possible. Whenever the extraction
to an interface is possible, that behavior is strongly encouraged.
As an example of the usage of this feature, this allows the ActivityIndicator.Color to be styled by CSS
Issues Resolved
/
API Changes
/
Platforms Affected
Behavioral/Visual Changes
/
PR Checklist