GH-968 Fix AtmospheresToPascals and PascalsToAtmospheres methods by pictos · Pull Request #969 · xamarin/Essentials

pictos · 2019-11-01T22:18:15Z

Description of Change

Correct the calc inside the method.

Bugs Fixed

Related to issue [Bug] In the UnitConverters class, the 2 methods AtmospheresToPascals and PascalsToAtmospheres are reversed #968

Provide links to issues here. Ensure that a GitHub issue was created for your feature or bug fix before sending PR.

Behavioral Changes

Now the methods AtmospheresToPascals and PascalsToAtmospheres returns the correct values.

PR Checklist

Has tests (if omitted, state reason in description)
Has samples (if omitted, state reason in description)
Rebased on top of master at time of PR
Changes adhere to coding standard
Updated documentation (see walkthrough)

ghost · 2019-11-01T22:19:22Z

Docs Build status updates of commit 5b117fe:

✅ Validation status: passed

File	Status	Preview URL	Details
Tests/UnitConverters_Tests.cs	✅Succeeded
Xamarin.Essentials/Types/UnitConverters.shared.cs	✅Succeeded

For more details, please refer to the build report.

Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

ghost · 2019-11-01T23:27:21Z

Docs Build status updates of commit 3965a41:

✅ Validation status: passed

File	Status	Preview URL	Details
Tests/UnitConverters_Tests.cs	✅Succeeded
Xamarin.Essentials/Types/UnitConverters.shared.cs	✅Succeeded
Xamarin.Essentials/Xamarin.Essentials.csproj	✅Succeeded

For more details, please refer to the build report.

Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

Redth · 2019-11-12T15:13:00Z

    <RepositoryUrl>https://github.com/xamarin/Essentials</RepositoryUrl>
    <PackageReleaseNotes>See: https://aka.ms/xamarinessentials-releasenotes</PackageReleaseNotes>
-    <LangVersion>7.3</LangVersion>
+    <LangVersion>8.0</LangVersion>


Can you please remove this language change from the PR, then I think it's good to go, thanks!

ghost · 2019-11-12T22:34:30Z

Docs Build status updates of commit 24addc6:

❌ Validation status: errors

Please follow instructions here which may help to resolve issue.

File	Status	Preview URL	Details
	❌Error		Details

[Error] Cannot sync git repo to specified state. Please make sure the pull request is mergeable. Details: Git merge results in conflict, repository remote url: https://github.com/xamarin/Essentials, working directory: W:\qdgf-s, target branch: HEAD, target branch commit: 7c0dc1ac29c722bab2258cdc7c6a09f1bc4a7ba5, source commit: 24addc61700fe1554d6fa2d43f953ac2b395cc32.

For more details, please refer to the build report.

Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

ghost · 2019-11-12T22:46:35Z

Docs Build status updates of commit 0a12a70:

⚠️ Validation status: warnings

File	Status	Details
	⚠️Warning	Details
Tests/UnitConverters_Tests.cs	✅Succeeded
Xamarin.Essentials/Types/UnitConverters.shared.cs	✅Succeeded

[Warning] Uid(Xamarin.Essentials.SizeExtensions.ToPlatformSize(System.Drawing.Size)_m) has already been defined in api/Xamarin.Essentials.SizeExtensions.ToPlatformSize.yml#Xamarin_Essentials_SizeExtensions_ToPlatformSize_System_Drawing_Size__m.
[Warning] Uid(Xamarin.Essentials.PointExtensions.ToPlatformPoint(System.Drawing.Point)_m) has already been defined in api/Xamarin.Essentials.PointExtensions.ToPlatformPoint.yml#Xamarin_Essentials_PointExtensions_ToPlatformPoint_System_Drawing_Point__m.
[Warning] Uid(Xamarin.Essentials.ColorExtensions.ToPlatformColor(System.Drawing.Color)_m) has already been defined in api/Xamarin.Essentials.ColorExtensions.ToPlatformColor.yml#Xamarin_Essentials_ColorExtensions_ToPlatformColor_System_Drawing_Color__m.
[Warning] Uid(Xamarin.Essentials.RectangleExtensions.ToPlatformRectangle(System.Drawing.Rectangle)_m) has already been defined in api/Xamarin.Essentials.RectangleExtensions.ToPlatformRectangle.yml#Xamarin_Essentials_RectangleExtensions_ToPlatformRectangle_System_Drawing_Rectangle__m.

For more details, please refer to the build report.

Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

pictos · 2019-11-14T00:03:55Z

@Redth I already did the changes, but it looks like the CI doesn't like me. Am I doing something wrong?

jamesmontemagno · 2019-11-15T19:07:01Z

CI should now be working again, validated the formulas. Good catch!

ghost · 2019-11-15T19:07:33Z

Docs Build status updates of commit 92afff6:

✅ Validation status: passed

File	Status	Preview URL	Details
Tests/UnitConverters_Tests.cs	✅Succeeded
Xamarin.Essentials/Types/UnitConverters.shared.cs	✅Succeeded

For more details, please refer to the build report.

Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

ghost · 2019-11-15T19:28:53Z

Docs Build status updates of commit a1b511a:

✅ Validation status: passed

File	Status	Preview URL	Details
Tests/UnitConverters_Tests.cs	✅Succeeded
Xamarin.Essentials/Types/UnitConverters.shared.cs	✅Succeeded

For more details, please refer to the build report.

Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

ghost · 2019-11-15T19:33:15Z

Docs Build status updates of commit 3447fa9:

✅ Validation status: passed

File	Status	Preview URL	Details
Tests/UnitConverters_Tests.cs	✅Succeeded
Xamarin.Essentials/Types/UnitConverters.shared.cs	✅Succeeded

For more details, please refer to the build report.

Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

ghost · 2019-11-15T19:47:48Z

Docs Build status updates of commit d3ed56f:

✅ Validation status: passed

File	Status	Preview URL	Details
Tests/UnitConverters_Tests.cs	✅Succeeded
Xamarin.Essentials/Types/UnitConverters.shared.cs	✅Succeeded

For more details, please refer to the build report.

Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

…ds (xamarin#969) * Fixed Atmosphere to Pascals converter * Added unit tests * Changed LangVer to 8.0 * Changed to C#7.3 * Update UnitConverters_Tests.cs * Fix spacing

* Use SharedPreferences.Editor.Apply when editing to force disk write to be asynchronous (#637) * GH-182 Color/Point/Rect/Size Extension Converters (#651) * Add extension helpers for iOS and Android * Add UWP colors and adjsut android colors. * Add UWP Point/Rect/Size * Rename and optimize! * Add tests and color helpers! * Fix unit test and add WithAlpha * Cleanup iOS as it stores it from 0-1 * Tests are all green! * Add generate-docs cmd :) * Add docs config to all :) * Additional clenaup for docs * Added some docs * Updated the mdoc target and regenerated the docs * Allow for code reuse on macOS (#665) Even though macOS is not yet officially supported, it is nice to reuse this code. macOS is exactly the same, except for this single property not supported. * GH-196 Browser Customization (#646) * Implemented GH-196 * Apply suggestions from code review: Naming Renamed incorrectly spelled variables Co-Authored-By: Mrnikbobjeff <schillinik@yahoo.de> * Implemented GH-196 * Browser update work as requested. Using System.Drawing.Color now * Adopted more review changes. Type forwarded. * Review changes * Made equals operator null safe, removed constructor * Add documentation and simplify the API! * Update viewmodel * Back to 7.2 * GH-676 Require To Check GPS Location is Fake Or Not In GeoLocation (#677) * Added bool IsFromMockProvider in Location class * Checkin * csproj original * Revert "csproj original" This reverts commit 6302b95. * Revert "Checkin" This reverts commit 0881e4f. * Revert "Added bool IsFromMockProvider in Location class" This reverts commit e56d940. * Revert the Xamarin.Essentials.csproj and Samples.Android.csproj to original; Adjust the property IsFromMockProvider in Location.shared and LocationExetensions. * Edited sample to show if the location is from moking provider. * Update docs * Fixes #694 (#699) * Update the mdoc to use the new minimum for VS2019 * GH-126: Finish Shake Detector API (#693) * Update CONTRIBUTING.md (#692) * GH-126 Detect Shake API (#666) * Added shaken support * name vhange * check-in * doc update * Implements the Shake API inside Accelerometer Class; Change sample to AccelorometerViewModel * Fix the sample project * Update the docs * Added Queue mechanism based off seismic with tests as well. Something is not right yet with calulating isaccelerating. * Finalize shake detection!!! * Re-generated the docs. * Fix the VM after merge * GH-704 Handle duplicate item in keychain (#705) * Update CONTRIBUTING.md (#692) * #704 if we get a duplicate item try to remove and then re-add if possible. * Initial commit Clipboard Change * Implemented Clipboard listeners on iOS, tested on android and uwp and fixed other issues related to Visual Studio for Mac and Essentials support. * Initial commit Clipboard Change * Implemented Clipboard listeners on iOS, tested on android and uwp and fixed other issues related to Visual Studio for Mac and Essentials support. * Naming fix * UI improvements * Docs update * docs update part 2 * docs tool breaking fix * reverted change to csproj

* Use SharedPreferences.Editor.Apply when editing to force disk write to be asynchronous (xamarin#637) * xamarinGH-182 Color/Point/Rect/Size Extension Converters (xamarin#651) * Add extension helpers for iOS and Android * Add UWP colors and adjsut android colors. * Add UWP Point/Rect/Size * Rename and optimize! * Add tests and color helpers! * Fix unit test and add WithAlpha * Cleanup iOS as it stores it from 0-1 * Tests are all green! * Add generate-docs cmd :) * Add docs config to all :) * Additional clenaup for docs * Added some docs * Updated the mdoc target and regenerated the docs * Allow for code reuse on macOS (xamarin#665) Even though macOS is not yet officially supported, it is nice to reuse this code. macOS is exactly the same, except for this single property not supported. * xamarinGH-196 Browser Customization (xamarin#646) * Implemented xamarinGH-196 * Apply suggestions from code review: Naming Renamed incorrectly spelled variables Co-Authored-By: Mrnikbobjeff <schillinik@yahoo.de> * Implemented xamarinGH-196 * Browser update work as requested. Using System.Drawing.Color now * Adopted more review changes. Type forwarded. * Review changes * Made equals operator null safe, removed constructor * Add documentation and simplify the API! * Update viewmodel * Back to 7.2 * xamarinGH-676 Require To Check GPS Location is Fake Or Not In GeoLocation (xamarin#677) * Added bool IsFromMockProvider in Location class * Checkin * csproj original * Revert "csproj original" This reverts commit 6302b95. * Revert "Checkin" This reverts commit 0881e4f. * Revert "Added bool IsFromMockProvider in Location class" This reverts commit e56d940. * Revert the Xamarin.Essentials.csproj and Samples.Android.csproj to original; Adjust the property IsFromMockProvider in Location.shared and LocationExetensions. * Edited sample to show if the location is from moking provider. * Update docs * Fixes xamarin#694 (xamarin#699) * Update the mdoc to use the new minimum for VS2019 * xamarinGH-126: Finish Shake Detector API (xamarin#693) * Update CONTRIBUTING.md (xamarin#692) * xamarinGH-126 Detect Shake API (xamarin#666) * Added shaken support * name vhange * check-in * doc update * Implements the Shake API inside Accelerometer Class; Change sample to AccelorometerViewModel * Fix the sample project * Update the docs * Added Queue mechanism based off seismic with tests as well. Something is not right yet with calulating isaccelerating. * Finalize shake detection!!! * Re-generated the docs. * Fix the VM after merge * xamarinGH-704 Handle duplicate item in keychain (xamarin#705) * Update CONTRIBUTING.md (xamarin#692) * xamarin#704 if we get a duplicate item try to remove and then re-add if possible. * Initial commit Clipboard Change * Implemented Clipboard listeners on iOS, tested on android and uwp and fixed other issues related to Visual Studio for Mac and Essentials support. * Initial commit Clipboard Change * Implemented Clipboard listeners on iOS, tested on android and uwp and fixed other issues related to Visual Studio for Mac and Essentials support. * Naming fix * UI improvements * Docs update * docs update part 2 * docs tool breaking fix * reverted change to csproj

pictos added 2 commits November 1, 2019 14:38

Fixed Atmosphere to Pascals converter

eb3e50e

Added unit tests

5b117fe

Changed LangVer to 8.0

3965a41

Redth reviewed Nov 12, 2019

View reviewed changes

Changed to C#7.3

24addc6

Merge branch 'master' into issue-968

0a12a70

jamesmontemagno previously approved these changes Nov 15, 2019

View reviewed changes

Merge branch 'master' into issue-968

92afff6

jamesmontemagno added this to the 1.4.0 milestone Nov 15, 2019

Merge branch 'master' into issue-968

a1b511a

Update UnitConverters_Tests.cs

3447fa9

jamesmontemagno dismissed their stale review via 3447fa9 November 15, 2019 19:32

Fix spacing

d3ed56f

jamesmontemagno approved these changes Nov 15, 2019

View reviewed changes

jamesmontemagno merged commit bedfe18 into xamarin:master Nov 15, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

GH-968 Fix AtmospheresToPascals and PascalsToAtmospheres methods#969

GH-968 Fix AtmospheresToPascals and PascalsToAtmospheres methods#969
jamesmontemagno merged 9 commits intoxamarin:masterfrom
pictos:issue-968

pictos commented Nov 1, 2019 •

edited by jamesmontemagno

Loading

Uh oh!

ghost commented Nov 1, 2019

Uh oh!

ghost commented Nov 1, 2019

Uh oh!

Redth Nov 12, 2019

Uh oh!

pictos Nov 13, 2019

Uh oh!

ghost commented Nov 12, 2019

Uh oh!

ghost commented Nov 12, 2019

Uh oh!

pictos commented Nov 14, 2019

Uh oh!

jamesmontemagno commented Nov 15, 2019

Uh oh!

ghost commented Nov 15, 2019

Uh oh!

ghost commented Nov 15, 2019

Uh oh!

ghost commented Nov 15, 2019

Uh oh!

ghost commented Nov 15, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

pictos commented Nov 1, 2019 • edited by jamesmontemagno Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description of Change

Bugs Fixed

Behavioral Changes

PR Checklist

Uh oh!

ghost commented Nov 1, 2019

✅ Validation status: passed

Uh oh!

ghost commented Nov 1, 2019

✅ Validation status: passed

Uh oh!

Redth Nov 12, 2019

Choose a reason for hiding this comment

Uh oh!

pictos Nov 13, 2019

Choose a reason for hiding this comment

Uh oh!

ghost commented Nov 12, 2019

❌ Validation status: errors

Uh oh!

ghost commented Nov 12, 2019

⚠️ Validation status: warnings

Uh oh!

pictos commented Nov 14, 2019

Uh oh!

jamesmontemagno commented Nov 15, 2019

Uh oh!

ghost commented Nov 15, 2019

✅ Validation status: passed

Uh oh!

ghost commented Nov 15, 2019

✅ Validation status: passed

Uh oh!

ghost commented Nov 15, 2019

✅ Validation status: passed

Uh oh!

ghost commented Nov 15, 2019

✅ Validation status: passed

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

pictos commented Nov 1, 2019 •

edited by jamesmontemagno

Loading