This repository was archived by the owner on May 15, 2024. It is now read-only.
macOS: TextToSpeech replaced NSSpeechBoundary#1430
Merged
mattleibow merged 2 commits intoxamarin:mainfrom Nov 6, 2020
Merged
Conversation
hWord is obsolete
| void TryCancel() | ||
| { | ||
| ss.StopSpeaking(NSSpeechBoundary.hWord); | ||
| ss.StopSpeaking(NSSpeechBoundary.Word); |
Collaborator
There was a problem hiding this comment.
This is a tricky one as this means anyone that hasn't updated to the latest version this may cause issues... @mattleibow ....
Member
There was a problem hiding this comment.
Yeah. I was thinking that.
But, this only applies to those building this source code. As enums are constants, only the value is used in IL.
It should be OK.
Member
There was a problem hiding this comment.
But, I think we should test to confirm my logic here. It should be a matter of just downloading this built assembly and viewing the IL.
I'll have a look to see.
mattleibow
added a commit
that referenced
this pull request
Nov 6, 2020
This reverts commit 38d78cb.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
hWordis obsolete, replaced it withWordBugs Fixed
PR Checklist
mainat time of PR