fix parsing on windows#92
Merged
jensneuse merged 1 commit intowundergraph:nextfrom Oct 27, 2019
pvormste:fix/schema-parsing-windows
Merged
fix parsing on windows#92jensneuse merged 1 commit intowundergraph:nextfrom pvormste:fix/schema-parsing-windows
jensneuse merged 1 commit intowundergraph:nextfrom
pvormste:fix/schema-parsing-windows
Conversation
jensneuse
pushed a commit
that referenced
this pull request
Feb 15, 2021
* add failing test in graphql package * fix argument templates not being resolved when not having spaces
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Schema parsing on Windows is broken, because the carriage return (CR, "
\r") is tokenized asIDENTinstead of a whitespace.So when parsing the default schema the parser throws following error:
This PR should fix this issue and the parser should work now on Windows.
Tests has been added too.