src/Tracker/VisitIdGenerator.php (2)

64-77: Performance: ensureCounterExists() adds an extra query on every visit ID generation.

This method is called on every generateNextVisitId() invocation, adding a SELECT COUNT(*) query before the atomic update. This means the "exactly 2 queries" claim in the PHPDoc is actually 3 queries in practice (or 4+ if initialization is needed).

Consider caching the existence check with a static flag, or restructuring to let the UPDATE handle missing rows gracefully (e.g., the UPDATE will affect 0 rows if the option doesn't exist, which you could detect and then initialize).

Also, use Yoda condition with strict comparison per coding guidelines:

♻️ Proposed optimization

+    private static bool $counterVerified = false;
+
     public static function ensureCounterExists(): void
     {
+        if (self::$counterVerified) {
+            return;
+        }
+
         global $wpdb;
 
         // Check if option exists
         $exists = $wpdb->get_var($wpdb->prepare(
             "SELECT COUNT(*) FROM {$wpdb->options} WHERE option_name = %s",
             self::OPTION_NAME
         ));
 
-        if ($exists == 0) {
+        if (0 === (int) $exists) {
             self::initializeCounter();
         }
+
+        self::$counterVerified = true;
     }

As per coding guidelines: "Use Yoda Conditions: if ( 'value' === $var )"

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@src/Tracker/VisitIdGenerator.php` around lines 64 - 77, ensureCounterExists()
currently issues a SELECT COUNT(*) on every call (invoked by
generateNextVisitId()), adding an extra query; remove this redundant check by
either (A) caching the existence with a static/class-level boolean in
ensureCounterExists() so the SELECT runs only once per request, or (B) eliminate
the SELECT entirely and let the atomic UPDATE in generateNextVisitId() run
first, detect when affected rows === 0 and then call initializeCounter(); update
the affected-rows check to use a Yoda strict comparison (0 === $affected) per
coding guidelines and reference the functions ensureCounterExists,
generateNextVisitId, and initializeCounter when making the change.

---

1-17: Missing declare(strict_types=1) and GPL license header.

Per coding guidelines, new PHP files should include declare(strict_types=1) at the top and a GPL license header. Additionally, the constant should use explicit visibility for PHP 7.1+ compatibility.

📝 Proposed fix

 <?php
+/**
+ * Atomic Visit ID Generator for SlimStat
+ *
+ * `@package` SlimStat
+ * `@license` GPL-2.0-or-later
+ */
+
+declare(strict_types=1);
 
 namespace SlimStat\Tracker;
 
 /**
  * Atomic Visit ID Generator for SlimStat
  *
  * Uses MySQL's LAST_INSERT_ID() for atomic increment operations,
  * providing thread-safe visit ID generation without race conditions.
  *
  * Performance: Always exactly 2 queries (O(1)) instead of O(n) collision loop.
  *
  * `@since` 5.4.1
  */
 class VisitIdGenerator
 {
-    const OPTION_NAME = 'slimstat_visit_id_counter';
+    public const OPTION_NAME = 'slimstat_visit_id_counter';

As per coding guidelines: "Use declare(strict_types=1); at the top of files where appropriate" and "Add GPL license headers to all new PHP files".

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@src/Tracker/VisitIdGenerator.php` around lines 1 - 17, The file is missing a
GPL license header, the declare(strict_types=1) directive, and explicit
visibility on the class constant; update the VisitIdGenerator file to add the
appropriate GPL license header at the top, add declare(strict_types=1);
immediately after the opening <?php, and change const OPTION_NAME to an
explicitly visible constant (e.g., public const OPTION_NAME) inside the
VisitIdGenerator class so it is compliant with PHP 7.1+ and project coding
guidelines.