Skip to content

Add email filter#1

Closed
sandrodz wants to merge 23 commits intowp-slimstat:masterfrom
sandrodz:master
Closed

Add email filter#1
sandrodz wants to merge 23 commits intowp-slimstat:masterfrom
sandrodz:master

Conversation

@sandrodz
Copy link
Copy Markdown

@sandrodz sandrodz commented May 2, 2019

Hi,

CRM integration plugins in the wild rely mostly on the user Email. Since slimdata only stores username, It is difficult to reliably connect CRM data with slimstat data.

I've added Email filter and corresponding column in the database. I think this addition makes plugin more versatile and easy to use with CRM.

If site owner wishes to add email data retroactively (not fresh install), following query can populate new email column with data from wp_users table:

UPDATE wp_slim_stats
INNER JOIN wp_users ON wp_slim_stats.username = wp_users.user_login
SET wp_slim_stats.email = wp_users.user_email

I didn't want to run this query during upgrade (with php), due to possibility of massive databases out there.

slimstat and others added 23 commits April 23, 2019 12:30
…ment, which unfortunately is not compatible with version 3.x and needs to be completely reimplemented
…core functionality is now working as expected
…er, which was causing Slimstat from incorrectly identifying visits as coming from mobile devices, instead of bots
…ance tab, to better troubleshoot issues related to these files
…s behind a Cloudflare load balancer. Please update the IP Address Fix add-on as well.
…d the associated description to better reflect the underlying calculations.
@slimstat slimstat force-pushed the master branch 2 times, most recently from 7f85bce to 91e360d Compare May 6, 2019 14:53
@slimstat
Copy link
Copy Markdown
Collaborator

slimstat commented May 7, 2019

Hi there! Thank you for submitting this pull request. I like this idea, and the reason behind it is more than valid. Since this mod would increase the database size, I am thinking that it should be implemented as a switch in the settings, so that admins can enable/disable it as needed. I'm quite sure most of our users would not really need it on their blogs with just a few users. Would you be interested in submitting a modified pull request that implements this as a setting?

@sandrodz
Copy link
Copy Markdown
Author

sandrodz commented May 7, 2019

Hey, thanks for the reply, yes I would gladly work on this PR.

@slimstat
Copy link
Copy Markdown
Collaborator

slimstat commented May 7, 2019

Terrific, thank you so much!

@slimstat slimstat closed this May 21, 2019
@slimstat
Copy link
Copy Markdown
Collaborator

Hi there, not sure if you're still working on this pull request. We're moving forward and implementing your feature in the next release.

Take care,
Jason

@sandrodz
Copy link
Copy Markdown
Author

@slimstat That's an awesome news. Unfortunatly I didn't have time to finish my PR :(

@slimstat
Copy link
Copy Markdown
Collaborator

No worries, I understand!

parhumm added a commit that referenced this pull request Mar 19, 2026
- Fix DB connection leak: close local pool in afterAll (CodeRabbit #1)
- Remove unused setSlimstatOptionDb function (CodeRabbit #2)
- Add limitation comment to setOption helper (CodeRabbit #3)
- Add pr239-production-scenarios.spec.ts (8 tests) covering:
  B1: Cached page simulation (stale nonce → 403 proof)
  B2: sendBeacon payload nonce safety
  B3: Transport fallback chain (REST→AJAX) without nonce
  B4: GDPR consent + nonce interaction
  B5: Logged-in user nonce regression check
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants