fix(release): align all plugin version metadata at deploy time, not just core#3918
Merged
Merged
Conversation
…ants.js The deploy job's safety-net sed for the plugin Version: header and the WPGRAPHQL_*_VERSION constant was hardcoded to wp-graphql.php + constants.php — i.e., the core plugin only. wp-graphql-ide, wp-graphql-smart-cache, and wp-graphql-acf had no equivalent backstop, which is the latent reason the IDE 5.0.0 release was able to ship a trunk with `Version: 4.5.0` inside `/tags/5.0.0/` once update-release-pr.yml failed mid-run. Replace the hardcoded sed with a call to update-version-constants.js — the same script update-release-pr.yml already uses to do the equivalent bump at release-PR creation time. The script reads constantMap from release-please-config.json per component, so every plugin defined in the config is covered (including any future fifth plugin added to the manifest). Locally smoke-tested against fixture build dirs for all four existing plugins; each main `Version:` header and each constant updates correctly, including the IDE's multi-space `Version: X.Y.Z` header format and core's two-place Version + @Version docblock. Parameterize the post-bump verify block off the same constantMap so the sanity grep follows the same single source of truth.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This was referenced Jun 10, 2026
jasonbahl
approved these changes
Jun 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The deploy job had a pre-ship "re-assert version metadata" backstop hardcoded to the core plugin's files only — IDE, ACF, and Smart Cache had no equivalent, which is why the IDE 5.0.0 release shipped with stale
Version: 4.5.0inside the SVN tag onceupdate-release-pr.ymlfailed mid-run.Replaces the hardcoded
sedwith the samescripts/update-version-constants.jsthe release-PR workflow already uses, so every plugin inrelease-please-config.jsonis covered automatically (any future fifth plugin gets the backstop for free). Smoke-tested locally against fixture build dirs for all four plugins.Defense-in-depth: even after #3916 and #3917 land, this catches the bad state at deploy time if either script ever regresses again — before wp.org sees it.
Merge order: