Skip to content

fix(release): align all plugin version metadata at deploy time, not just core#3918

Merged
jasonbahl merged 2 commits into
mainfrom
fix/release-deploy-version-bump-via-script
Jun 10, 2026
Merged

fix(release): align all plugin version metadata at deploy time, not just core#3918
jasonbahl merged 2 commits into
mainfrom
fix/release-deploy-version-bump-via-script

Conversation

@josephfusco

@josephfusco josephfusco commented Jun 10, 2026

Copy link
Copy Markdown
Member

The deploy job had a pre-ship "re-assert version metadata" backstop hardcoded to the core plugin's files only — IDE, ACF, and Smart Cache had no equivalent, which is why the IDE 5.0.0 release shipped with stale Version: 4.5.0 inside the SVN tag once update-release-pr.yml failed mid-run.

Replaces the hardcoded sed with the same scripts/update-version-constants.js the release-PR workflow already uses, so every plugin in release-please-config.json is covered automatically (any future fifth plugin gets the backstop for free). Smoke-tested locally against fixture build dirs for all four plugins.

Defense-in-depth: even after #3916 and #3917 land, this catches the bad state at deploy time if either script ever regresses again — before wp.org sees it.


Merge order:

  1. fix(release): release script writes changelog entries into the right readme section #3917 — section-scope fix
  2. fix(release): release script no longer crashes mid-run updating readme.txt #3916 — release-script crash fix
  3. 👉 fix(release): align all plugin version metadata at deploy time, not just core #3918 (this PR) — deploy-time backstop

…ants.js

The deploy job's safety-net sed for the plugin Version: header and the
WPGRAPHQL_*_VERSION constant was hardcoded to wp-graphql.php +
constants.php — i.e., the core plugin only. wp-graphql-ide,
wp-graphql-smart-cache, and wp-graphql-acf had no equivalent backstop,
which is the latent reason the IDE 5.0.0 release was able to ship a
trunk with `Version: 4.5.0` inside `/tags/5.0.0/` once
update-release-pr.yml failed mid-run.

Replace the hardcoded sed with a call to update-version-constants.js —
the same script update-release-pr.yml already uses to do the equivalent
bump at release-PR creation time. The script reads constantMap from
release-please-config.json per component, so every plugin defined in
the config is covered (including any future fifth plugin added to the
manifest). Locally smoke-tested against fixture build dirs for all four
existing plugins; each main `Version:` header and each constant updates
correctly, including the IDE's multi-space `Version:           X.Y.Z`
header format and core's two-place Version + @Version docblock.

Parameterize the post-bump verify block off the same constantMap so the
sanity grep follows the same single source of truth.
@vercel

vercel Bot commented Jun 10, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
wpgraphql-com Ready Ready Preview, Comment Jun 10, 2026 9:19pm

@josephfusco josephfusco changed the title fix(release): drive deploy-time version bump via update-version-constants.js fix(release): align all plugin version metadata at deploy time, not just core Jun 10, 2026
@josephfusco josephfusco marked this pull request as ready for review June 10, 2026 20:41
@jasonbahl jasonbahl merged commit 41b3ab0 into main Jun 10, 2026
38 checks passed
@jasonbahl jasonbahl deleted the fix/release-deploy-version-bump-via-script branch June 10, 2026 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants