test: backfill nodeByUri query testing#2659
Merged
jasonbahl merged 24 commits intowp-graphql:developfrom Feb 14, 2023
Merged
Conversation
nodeByUri query testingnodeByUri query testing
16 tasks
2286eb5 to
9f0f22c
Compare
4c5cded to
548979a
Compare
ccb7405 to
fa10c04
Compare
Collaborator
Author
|
@jasonbahl I'm going to get started on refactoring work using this as the base branch, but like I wrote in the (updated) description, I dont think we should wait to fix the issues in |
|
Code Climate has analyzed commit 459c8ec and detected 0 issues on this pull request. View more on Code Climate. |
jasonbahl
approved these changes
Feb 14, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this implement/fix? Explain your changes.
This PR backfills
NodeByUriTestto cover both untested cases coded for inNodeResolver::resolve_uri(), as well as additional edge cases.Failing edge cases are marked incomplete.
What's included
$query_varsare being tested for each query; and fixed/expanded testing with/without pretty permalinks.#anchors(URI inputs should sanitize anchor links from uris #1712 )What's not included
add_rewrite_tag()andadd_permastruct(). I'm not familiar enough with these methods to write a test.Issues uncovered
The following test cases fail (as of WPGraphQL v1.13.7)
nodeByUriqueries #2191)These tests have been marked incomplete.
Does this close any currently open issues?
Part of #2366
Any relevant logs, error output, GraphiQL screenshots, etc?
(If it’s long, please paste to https://ghostbin.com/ and insert the link here.)
Any other comments?
URI#2366.Where has this been tested?
Operating System: Ubuntu 20.04 (wsl2 + devilbox + PHP 8.0.19)
WordPress Version: 6.1.1