-
Notifications
You must be signed in to change notification settings - Fork 468
URI inputs should sanitize anchor links from uris #1712
Copy link
Copy link
Closed
Labels
close candidateNeeds confirmation before closingNeeds confirmation before closingcomponent: queryRelating to GraphQL QueriesRelating to GraphQL Queriesobject type: mediaRelating to the MediaItem TypeRelating to the MediaItem Typeobject type: postRelating to the Post Object TypesRelating to the Post Object Typesobject type: termRelating to the Term TypesRelating to the Term Typesobject type: userRelating to the User TypeRelating to the User Typestale?May need to be revalidated due to prolonged inactivityMay need to be revalidated due to prolonged inactivitystatus: actionableReady for work to beginReady for work to begintype: enhancementImprovements to existing functionalityImprovements to existing functionality
Milestone
Description
Problem
When a page has a path such as my-page/#some-anchor-link, many clients will pass that as the id for a nodeByUri query.
While we could argue that the client should sanitize this and remove the anchor from the path prior to making a WPGraphQL request, I think it's reasonable to expect this will be sent to the server by many clients.
Proposal
Wherever nodes can be fetched by URI input, WPGraphQL should take into consideration that anchor links might included in the paths and resolve to the correct node.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
close candidateNeeds confirmation before closingNeeds confirmation before closingcomponent: queryRelating to GraphQL QueriesRelating to GraphQL Queriesobject type: mediaRelating to the MediaItem TypeRelating to the MediaItem Typeobject type: postRelating to the Post Object TypesRelating to the Post Object Typesobject type: termRelating to the Term TypesRelating to the Term Typesobject type: userRelating to the User TypeRelating to the User Typestale?May need to be revalidated due to prolonged inactivityMay need to be revalidated due to prolonged inactivitystatus: actionableReady for work to beginReady for work to begintype: enhancementImprovements to existing functionalityImprovements to existing functionality
Type
Projects
Status
✅ Done