Add filter to allow opt-out of WebDAV Edit Document#74
Merged
benbalter merged 1 commit intowp-document-revisions:masterfrom Nov 12, 2014
jeremyfelt:filter-web-dav
Merged
Add filter to allow opt-out of WebDAV Edit Document#74benbalter merged 1 commit intowp-document-revisions:masterfrom jeremyfelt:filter-web-dav
benbalter merged 1 commit intowp-document-revisions:masterfrom
jeremyfelt:filter-web-dav
Conversation
Retains current functionality by being `true` by default and allows sites to opt out of loading the browser plugin.
Collaborator
|
Makes sense. Thanks for the pull request! 🌴 |
benbalter
added a commit
that referenced
this pull request
Nov 12, 2014
Add filter to allow opt-out of WebDAV Edit Document
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When editing a document in Chrome, without support for WebDAV enabled on the server and without authorizing any plugins to load when in the document admin, I get a "Plug-in Blocked" error every time I load the page.
WebDAV seems really cool, but I don't have the bandwidth to figure out how to serve it properly and securely in our current configuration. I think at least parts of this should be opt-in, as not everyone will be WebDAV savvy.
Adding a filter for
document_revisions_enable_webdavto opt out seems like a straight forward approach. It at least avoids loading the markup, though the JS continues to be available. Happy to discuss others as well.Great plugin, thanks! :)