Saving workflow state#48
Merged
benbalter merged 1 commit intowp-document-revisions:masterfrom Mar 15, 2013
Merged
Conversation
benbalter
added a commit
that referenced
this pull request
Mar 15, 2013
Compare workflow state slug, not ID, props @cojennin
benbalter
pushed a commit
that referenced
this pull request
Feb 28, 2023
Update dealerdirect/phpcodesniffer-composer-installer requirement
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
$_POST['workflow-state'] is a slug, not an id. So compare slugs, not ids. Related to these two issues: #1 #2
The most recent change invalidates the need for this (it just always updates regardless), but it might be confusing down the road if the comparison is slugs and ids.