Update class-wp-document-revisions.php - property subdir is required.#342
Merged
benbalter merged 1 commit intowp-document-revisions:mainfrom Mar 8, 2024
Merged
Conversation
Contributor
Author
|
FWIW. WP Media Offload shows a notice and depreciation warning due to the missing property. |
benbalter
approved these changes
Mar 8, 2024
Contributor
Author
|
Thanks for merging :) |
NeilWJames
added a commit
to NeilWJames/wp-document-revisions
that referenced
this pull request
Mar 11, 2024
…t-revisions#342) A fix has been made available. This updates the fix to make it consistent. [If the option "Organize my uploads into month- and year-based folders" is ticked, then the value should be set to yyyy/mm.
Merged
Collaborator
|
Thanks for identifying the issue. |
|
Hi, I'm Erik from the WP Offload Media dev team. First, thank you @earthlingdavey for reporting this and also suggesting a fix in our plugin. Also thanks to @NeilWJames for looking into this and solving it so quickly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Property subdir is required, so don't remove it during the filter, just set it to an empty string.
https://developer.wordpress.org/reference/functions/wp_upload_dir/