Re-evaluate the decision to make WP_ADMIN => true#674
Conversation
|
What we could do differently this time around is load the admin utilities only when needed. This should speed up start times a bit. |
|
Waiting for the onslaught of failed tests... |
There was a problem hiding this comment.
This missing line is causing errors in plugin.feature and theme.feature: https://travis-ci.org/wp-cli/wp-cli/jobs/10164422
I don't want to add it back, because some plugins hook to it to do redirects, which is what we're trying to avoid.
There was a problem hiding this comment.
The problem is that wp plugin list doesn't call wp_update_plugins(), like wp plugin status does.
|
Ah hah! This is what was breaking my multisite install the other week. Was running an import and it kept failing when I specified the url. Ended up rewriting my code to be arbitrary and just use a switch_to_blog() call so it didn't require specifying a site on the command line. This is an interesting issue and I'm not sure any answer will be easy. Unless I have a stroke of genius, I doubt I'll be the one earning a gold star ;) |
|
Welcome |
There have been a continuous stream of bug reports since #385 landed (particularly b42005e)
WP_ADMIN: true
WP-CLI breaks completely, because several types of plugins issue redirects and then call
exit:--user=someadminwp site listdoesn't work with domain mapping #669)WP_ADMIN: false
Plugins that check
is_admin()before loading part of their code won't work correctly, but most WP-CLI commands continue to work just fine.