A class @when shouldn't overrides individual method @whens. #4458
Merged
danielbachhuber merged 10 commits intomasterfrom Oct 24, 2017
Merged
A class @when shouldn't overrides individual method @whens. #4458danielbachhuber merged 10 commits intomasterfrom
@when shouldn't overrides individual method @whens. #4458danielbachhuber merged 10 commits intomasterfrom
Conversation
Member
Author
|
I removed |
Member
Author
|
I changed my mind. 😊 |
danielbachhuber
requested changes
Oct 23, 2017
features/command.feature
Outdated
| * @when after_wp_load | ||
| */ | ||
| public function home_url() { | ||
| WP_CLI::success( home_url() ); |
Member
There was a problem hiding this comment.
To make these tests more precise, could we have each method var_dump( function_exists( 'home_url' ) )?
With this approach, we'll know definitely whether WordPress has loaded or not.
Member
Author
It is nice idea. I did it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4350