Composer: Add WPCS as a local dev dependency#4339
Conversation
|
Huh! The DealerDirect Composer plugin breaks on PHP 5.3, which is the required minimum we're testing against. |
|
See error here: https://travis-ci.org/wp-cli/wp-cli/jobs/273239552#L212 |
I'll see if I can do a PR to make it 5.3 compatible, since it only seems to be short array syntax that's the issue.
|
|
PHPCSStandards/composer-installer#39 submitted. If / when this is merged and released, I'll adjust the PR here to require |
357287c to
0a36c29
Compare
|
Rebased to avoid merge conflict. |
If this package should be tested against PHPCS + WPCS, then these development dependencies should be available locally, and not rely on a contributor having it available globally, with what might be out of date versions. WPCS is stable enough to facilitate a version of `dev-develop`, but I've stuck with the latest tag for now, so that new fixes can be applied in a controlled manner. The DealerDirect Composer plugin allows the automatic registration of code standards that include the `type` of `phpcodesniffer-standard`, and is recommended by WPCS.
0a36c29 to
8478bc9
Compare
|
FYI: The related merge-request(s) in |
|
@Potherca Thanks for letting us know! @GaryJones , can you adapt the PR so that it requires a minimum of |
Will do :-) |
If this package should be tested against PHPCS + WPCS, then these development dependencies should be available locally, and not rely on a contributor having it available globally, with what might be out of date versions.
WPCS is stable enough to facilitate a version of
dev-develop, but I've stuck with the latest tag for now, so that new fixes can be applied in a controlled manner.The DealerDirect Composer plugin allows the automatic registration of code standards that include the
typeofphpcodesniffer-standard, and is recommended by WPCS.Replaces part of #4335.