Conversation
Member
Author
|
Even worse, |
Member
Author
|
Should test both multisite and single site, since they have different loading code. |
The more precise assertions expose several buggy tests. Also reverts WP_CLI::error() second parameter to $label, since sending the first line to STDERR and subsequent ones to STDOUT is confusing. If you want to have a multiline error message, just insert \n characters.
scribu
pushed a commit
that referenced
this pull request
Feb 8, 2013
"Error Connecting To Database" HTML output
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Steps to reproduce:
wpYou'll get the error message embeded in a ton of useless HTML, instead of a nice
WP_CLI::error()message.