Skip to content

Checksums for nightly builds#1555

Merged
danielbachhuber merged 5 commits intowp-cli:masterfrom
nyordanov:phar-signature
Feb 20, 2015
Merged

Checksums for nightly builds#1555
danielbachhuber merged 5 commits intowp-cli:masterfrom
nyordanov:phar-signature

Conversation

@nyordanov
Copy link
Contributor

This fixes #1199

Also makes sure that the built-in Phar signature uses SHA-512.

@nyordanov nyordanov mentioned this pull request Dec 13, 2014
5 tasks
@danielbachhuber
Copy link
Member

@nyordanov can you update so this merges cleanly?

@szepeviktor
Copy link
Contributor

Very nice feature.

@nyordanov
Copy link
Contributor Author

@danielbachhuber done

@danielbachhuber danielbachhuber added the scope:distribution Related to distribution label Dec 30, 2014
@danielbachhuber danielbachhuber added this to the next milestone Dec 30, 2014
@danielbachhuber
Copy link
Member

... if only the damn build would pass...

@danielbachhuber
Copy link
Member

@nyordanov I've restarted this build a half dozen times and it always get stuck on the same thing. Can you reproduce locally?

@danielbachhuber danielbachhuber modified the milestone: next Jan 14, 2015
@nyordanov
Copy link
Contributor Author

@danielbachhuber the tests pass when I run them locally, but I only have php 5.5 right now and I've noticed that Travis fails only on 5.3. I'm busy until the end of next week, so I won't be able be able to look more closely into what's causing this until then.

If the problem is not fixed by then, I'll try to fix it when I'm back.

@danielbachhuber
Copy link
Member

Odd. I'd expect them to fail across the board if it was a PHP version issue. Can you merge master once more?

@nyordanov
Copy link
Contributor Author

I just can't reproduce this locally. I tried the same PHP version as Travis (5.3.29) and the rewrite tests pass just fine. Yet, they consistently fail in Travis.

Any idea what's behind the 255 exit code?

@danielbachhuber
Copy link
Member

No idea. Maybe the merge failed in some uncommunicated way. Can you create a fresh branch off master and cherry-pick your commit?

@nyordanov
Copy link
Contributor Author

It looks like it was a PHP 5.3 issue after all (or possibly specific to the 5.3 used by Travis?). The tests pass if I don't force SHA512 to be used as the algorithm for the Phar self-check.

@danielbachhuber danielbachhuber added this to the next milestone Feb 20, 2015
@danielbachhuber
Copy link
Member

It looks like it was a PHP 5.3 issue after all (or possibly specific to the 5.3 used by Travis?).

The road to hell is paved with CI errors you can't replicate locally.

danielbachhuber added a commit that referenced this pull request Feb 20, 2015
@danielbachhuber danielbachhuber merged commit 805f15e into wp-cli:master Feb 20, 2015
@nyordanov
Copy link
Contributor Author

@danielbachhuber have I broken the commits to https://github.com/wp-cli/builds? The last build is b09a45a

@danielbachhuber
Copy link
Member

image

@danielbachhuber
Copy link
Member

8b59d51

Thanks for following up on this, @nyordanov

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

scope:distribution Related to distribution

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Publish checksums for builds

3 participants