Implement CS checking based on the WP_CLI_CS ruleset
#55
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schlessera
requested changes
Apr 21, 2019
Co-Authored-By: wojsmol <wojsmol@wp.pl>
Co-Authored-By: wojsmol <wojsmol@wp.pl>
Co-Authored-By: wojsmol <wojsmol@wp.pl>
Co-Authored-By: wojsmol <wojsmol@wp.pl>
Co-Authored-By: wojsmol <wojsmol@wp.pl>
Co-Authored-By: wojsmol <wojsmol@wp.pl>
Co-Authored-By: wojsmol <wojsmol@wp.pl>
Co-Authored-By: wojsmol <wojsmol@wp.pl>
schlessera
requested changes
Apr 21, 2019
Member
schlessera
left a comment
There was a problem hiding this comment.
There's another \WP_CLI\Utils\extract_from_phar() in line 94 that you can simplify through the import.
schlessera
requested changes
Apr 21, 2019
Co-Authored-By: wojsmol <wojsmol@wp.pl>
schlessera
requested changes
Apr 21, 2019
Member
schlessera
left a comment
There was a problem hiding this comment.
LGTM, just two minor whitespace issues and then we can merge.
Co-Authored-By: wojsmol <wojsmol@wp.pl>
Co-Authored-By: wojsmol <wojsmol@wp.pl>
schlessera
approved these changes
Apr 21, 2019
schlessera
added a commit
that referenced
this pull request
Jan 5, 2022
Implement CS checking based on the `WP_CLI_CS` ruleset
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a PHPCS ruleset using the new WP_CLI_CS standard.
Fixes #53
Related wp-cli/wp-cli#5179